[uss_qualifier] monitorlib: ISAChange exposes subscribers as returned by DSS #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
rid-isa-change-expose-subscribers
branch
2 times, most recently
from
b9c3b9e to
8e46667
Compare
mickmis
reviewed
Nov 5, 2024
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
PR title: this looks more like a monitorlib change.
monitoring/monitorlib/mutate/rid.py
Outdated
| notifications: Dict[str, ISAChangeNotification] | ||
| """Mapping from USS base URL to change notification query""" | ||
|
|
||
| subscribers: List[SubscriberToNotify] |
Contributor
There was a problem hiding this comment.
It looks this always contains dss_query.subscribers: rather than a new field why not adding a property returning that?
Contributor
Author
There was a problem hiding this comment.
Indeed, that is the straightforward solution
| import arrow | ||
| import s2sphere | ||
| from uas_standards.astm.f3411 import v19, v22a | ||
| from zope.event import subscribers |
Contributor
Author
There was a problem hiding this comment.
Auto-complete artifact, fishy indeed
Shastick
changed the title
Shastick
force-pushed
the
rid-isa-change-expose-subscribers
branch
from
8e46667 to
d0813ae
Compare
Contributor
Author
|
Updated as suggested. |
mickmis
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of the
DSSWrapperto easily check which subscribers were mentioned in a response to create, mutate or delete an ISA on the DSS.Up to now this could be reconstructed by looking at the notifications that were effectively sent by the wrapper, but this was needlessly cumbersome and breaks down when the qualifier ignores notifications that should be sent to itself.
(This change was required by #839)