-
Notifications
You must be signed in to change notification settings - Fork 0
Feature parity #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature parity #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the input handling system to include support for toggle and select types. Introduced conditional visibility logic for dynamic forms. Enhanced cluster creation features with autoscaling configurations and validations.
Callum0x50
previously requested changes
Nov 4, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member
Member
Error was due to binary running on staging instead of production env. Worked as intended when using production.
Member
|
Added in the positional parameters in this PR. Will leave the other comments for subsequent PRs instead of extending this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




This pull request introduces several significant improvements and new features to the cluster management workflow, wizard UI, and client interfaces. The main highlights include support for autoscaling node pools during cluster creation, new cluster inspection commands (get and status), a more flexible and dynamic wizard interface with select and toggle fields, the introduction of an integration client, and CI/linting improvements. There are also code quality improvements and bug fixes.
Cluster Creation Enhancements:
pkg/commands/cluster/create.go[1] [2] [3] [4]NewClusterRequestandNodePooltypes were updated to support autoscaling, SSO provisioner selection, and additional configuration fields. (pkg/client/cluster.gopkg/client/cluster.goR29-R44)Wizard UI Improvements:
internal/wizard/wizard.go[1] [2] [3] [4] [5] [6]internal/wizard/wizard.go[1] [2] [3] [4] [5]Client and Integration API:
IntegrationClientinterface and implemented a method to list integration instances via the platform API. (pkg/client/client.go[1]pkg/client/integration.go[2]Cluster Management Commands:
cluster getcommand to display detailed information about a specific cluster, including configuration, node pools, compute resources, and status inpkg/commands/cluster/get.go.cluster statuscommand to quickly check the deployment and ready status of a cluster inpkg/commands/cluster/status.go.cluster listcommand to display additional information including cluster version, node pool summaries (pool count and node count), and assigned roles inpkg/commands/cluster/list.go.Clustertype with new fields:ID,Version,NodePools, andRoles. TheNodePooltype now includesIDandComputeResourcesfor detailed resource information inpkg/client/cluster.go.GetClusterStatusmethod to theClusterClientinterface for retrieving real-time cluster status inpkg/client/client.go.CI and Code Quality Improvements:
mocks,internal/telemetry) from linting checks, reducing noise in CI runs in.golangci.yaml.SilenceErrors: trueto the root command for better error handling consistency inpkg/rootcommand/rootcommand.go.Documentation:
docs/create_cluster_interactive.tapeanddocs/create_cluster_interactive.gif.Code Quality and Formatting Fixes:
ux.Ferror,ux.Fprint, andux.Fsuccessto use formatted strings across the codebase for consistency. (cmd/indev/main.go[1] [2]internal/cli/cli.go[3] [4]pkg/commands/account/login.go[5]go.modto 1.24.6. (go.modgo.modL3-R3)These changes collectively make the cluster management experience more comprehensive and user-friendly, from creation to inspection. The new
getandstatuscommands provide better visibility into cluster state, while the enhanced wizard interface and autoscaling support make cluster creation more flexible. The CI improvements and code quality fixes ensure better maintainability as the codebase grows and prepares the foundation for future integration features.