Add cluster commands to login and open in browser #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds commands that allow users to login to their clusters by running
indev cluster login <clusterName>Also adds a command to open the openshift console in a browser window by running
indev cluster open <clusterName>While this branch is entirely functional, I'm unsure how I feel about wrapping
oc. This obviously puts a requirement for an external binary to be present for these commands to work, and we're also doing os/exec to run theoccommands which I feel a bit uncomfortable doing.As alternative options I have looked into using the oc or kubectl libraries as an SDK instead, but these both come with big trade-offs and introduce a lot of extra code complexity that I would rather avoid.
Going to have to think this one through and gather some opinions from others before moving on.