Splitting dynamic path matching from path generation,#693
Closed
BRMatt wants to merge 1 commit intoomniauth:masterfrom
memberful:630-rename-callbacks
Closed
Splitting dynamic path matching from path generation,#693BRMatt wants to merge 1 commit intoomniauth:masterfrom memberful:630-rename-callbacks
BRMatt wants to merge 1 commit intoomniauth:masterfrom
memberful:630-rename-callbacks
Conversation
Previously the lambda was responsible for matching the incoming request path and returning a truthy value, AND returning a string representation of the callback_path This breaking change introduces two new callbacks `is_request_path` and `is_callback_path` which handle the dynamic path matching, and the original callbacks can be used for path generation. refs #630
sferik
force-pushed
the
master
branch
2 times, most recently
from
a5c7282 to
76feeea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the lambda was responsible for matching the incoming request
path and returning a truthy value, AND returning a string representation
of the callback_path
This breaking change introduces two new callbacks
is_request_pathandis_callback_pathwhich handle the dynamic path matching, and theoriginal callbacks can be used for path generation.
refs #630