Add tests for CDC Result processing in callback interceptor (#60) #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatiushkin
commented
Oct 21, 2019
Comment on lines
+63
to
+72
| public void errorNoResponse() throws FMSException { | ||
| final CDCResponse o = new CDCResponse(); | ||
| final Fault fault = new Fault(); | ||
| final Error error = new Error(); | ||
| fault.setError(Collections.singletonList(error)); | ||
| error.setDetail("My custom error"); | ||
| o.setFault(fault); | ||
| o.setQueryResponse(null); | ||
|
|
||
| assertNotNull(results); | ||
| assertFalse(results.isEmpty()); | ||
| assertEquals(1, results.size()); | ||
| assertEmptyResult(invokeCDC(Collections.singletonList(o))); |
Author
There was a problem hiding this comment.
I think this uncovers either dead code in callback interceptor or potential defect. My expectation here is to be able to get error back.
diana-derose
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests for CDC Result processing during callback
@diana-derose FYI