Propagate fault even there is no responses (#75) #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Coverage should be better with #74 :) |
diana-derose
approved these changes
Oct 23, 2019
Collaborator
|
Alex - This looks good, the PR is still in draft so can't merge. Let me know once complete and I'll merge this along with #74 |
Author
|
@diana-derose let's take #74 first, I do expect one new test to fail and to be re-implemented in scope of this PR. |
Author
|
@diana-derose it is ready :) |
diana-derose
approved these changes
Oct 29, 2019
Collaborator
|
Looks good, thanks @amatiushkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75