Skip to content

[SRE-30912] Disallow Doctype Declaration#323

Merged
kevin-mcgoldrick merged 4 commits intomasterfrom
SRE-30912
May 1, 2024
Merged

[SRE-30912] Disallow Doctype Declaration#323
kevin-mcgoldrick merged 4 commits intomasterfrom
SRE-30912

Conversation

@kevin-mcgoldrick
Copy link
Collaborator

Disallow Doctype Declaration

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-mcgoldrick kevin-mcgoldrick merged commit 0620d92 into master May 1, 2024
@kevin-mcgoldrick kevin-mcgoldrick deleted the SRE-30912 branch May 1, 2024 18:57
kevin-mcgoldrick added a commit that referenced this pull request May 1, 2024
* master:
  [SRE-30912] Disallow Doctype Declaration (#323)
  IMDSv2 (#322)
Zakaria-Kofiro pushed a commit that referenced this pull request Jun 18, 2024
* Disallow Doctype Decleration

* disable DTD in XMLInputFactory of the ScriptProcessor
---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>
Zakaria-Kofiro added a commit that referenced this pull request Sep 20, 2024
* filter by content-type to save responseData

* Add client5

* Refactor checkContentType to use AgentConfig for MIME types

* IMDSv2 (#322)

* [SRE-30912] Disallow Doctype Declaration (#323)

* Disallow Doctype Decleration

* disable DTD in XMLInputFactory of the ScriptProcessor
---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>

* Nonlinear Workload - Calculate Number of Agents based on Total Ramp Rate and Max Users/Sec per Agent (#320)

* initial implementation

* unneeded

---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>

* [SRE-30568] Tank V2 API Module Refactor (#324)

* Tank V2 API Module Refactor

* unneeded test file

* updating pom

* missing resource file for tests

* update all requests w/ auth header

* small updates, unneeded files

---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>

* Update POST /scripts endpoint and add "Copy From Script" functionality (#325)

* Tank V2 API Module Refactor

* unneeded test file

* updating pom

* missing resource file for tests

* update all requests w/ auth header

* moving to new branch

* small updates, unneeded files

* small fixes, unit tests, and fix for script upload error

* match convention

---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>

* null checks for input (#326)

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>

* JDK httpclient (HTTP/2.0) (#327)

* Add JDK Http Client
* Remove: apache httpclient 5

* library updates (#328)

* Simplify slow call logging events (#329)

* Refactor checkContentType to use AgentConfig for MIME types

* removing http client 5

* updated for JDK client

* create TankConfig once

* pull mimeTypes once + update checkContentType

---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>
Co-authored-by: Kevin McGoldrick <kevin_mcgoldrick@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants