Fix: Handle Controller Restarts#337
Merged
Zakaria-Kofiro merged 2 commits intomasterfrom Jul 18, 2024
Merged
Conversation
added 2 commits
July 17, 2024 14:02
kevin-mcgoldrick
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Handle Controller Restarts
When the Tank controller restarts, it maintains connectivity to its running agents via
findAgent()which creates anec2clientper region to pull instance data. This allows the controller to pull each agent's instance URL to send agent commands (start, stop, pause, and kill). Previously, it only did this for a single region (getConfiguredRegions()) - the region the controller was in - resulting in failed calls to agents in other regions. This fixes this issue by looping through all available agent regions (getRegions()), and thus has no issue in connecting to any running agents after a controller restart.Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **