Ensure Tank Jobs correctly stop when Simulation Time is met#346
Merged
Zakaria-Kofiro merged 1 commit intomasterfrom Nov 14, 2024
Merged
Ensure Tank Jobs correctly stop when Simulation Time is met#346Zakaria-Kofiro merged 1 commit intomasterfrom
Zakaria-Kofiro merged 1 commit intomasterfrom
Conversation
kevin-mcgoldrick
approved these changes
Nov 14, 2024
kevin-mcgoldrick
added a commit
that referenced
this pull request
Jan 16, 2025
* master: (46 commits) Update doPUT to add boundary to multi-part + add doPatch (#363) Reduce Regex on RESPONSE_BODY (#362) CVE-2024-38827 (#351) add JobMakerTest (#361) Update AWS bom (#359) Bump org.apache.tomcat:tomcat-catalina from 11.0.1 to 11.0.2 (#357) updating command (#356) Update AgentStartup command to pass in list of arguments (#355) Enable Connection Manager Sharing in Apache Http 4.5 (#353) Agent Debugger Export Responses (CSV) (#350) Update Tomcat Release to 11 Project SaveAs now correctly copies all project values (#345) make sure that simulation time is met (#346) Prep Snapshot 4.1.1 Release 4.1.0 Library Updates (#344) single instance object mapper shared for the life of the apimonitor (#343) Filter by content-type to save responseBody (#321) cancel button working when canceling script group deletion (#342) Updating Agent Startup Command (#341) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure Tank Jobs correctly stop when Simulation Time is met
Sometimes, Tank jobs ignore the check for simulation time and continue running nonetheless - this extra check ensures the jobs stop after simulation time is met by checking against a volatile boolean variable, which is flipped once simulation time is met and checked at the start of every loop.
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **