Skip to content

Capture and Log Proxy Response Time in Agent Debugger#352

Merged
Zakaria-Kofiro merged 11 commits intomasterfrom
zkofiro/response-time-reporting
Jan 23, 2025
Merged

Capture and Log Proxy Response Time in Agent Debugger#352
Zakaria-Kofiro merged 11 commits intomasterfrom
zkofiro/response-time-reporting

Conversation

@Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Dec 4, 2024

Capture and Log Istio Response Time in Agent Debugger

  • Capture istio response/service time from services via x-envoy-upstream-service-time header, log in both Debugger tool and CSV export file
  • Escape special characters (i.e commas) in Request URL when exporting CSV response data from Agent Debugger tool
  • Set Apache HttpClient 4.5 as default client in Agent Debugger tool

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title Capture and Log Isitio Response Time in Agent Debugger Capture and Log Istio Response Time in Agent Debugger Dec 4, 2024
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename ISTIO to PROXY, so that this can be generalized in the future to support more than just istio (envoy, nginx, apache).

@Zakaria-Kofiro Zakaria-Kofiro changed the title Capture and Log Istio Response Time in Agent Debugger Capture and Log Proxy Response Time in Agent Debugger Jan 23, 2025
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakaria-Kofiro Zakaria-Kofiro merged commit db5a51d into master Jan 23, 2025
3 checks passed
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/response-time-reporting branch January 23, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants