Skip to content

AWS Ec2AsyncClient#377

Merged
kevin-mcgoldrick merged 10 commits intomasterfrom
Ec2AsyncClient
Mar 4, 2025
Merged

AWS Ec2AsyncClient#377
kevin-mcgoldrick merged 10 commits intomasterfrom
Ec2AsyncClient

Conversation

@kevin-mcgoldrick
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick commented Feb 25, 2025

Re-write of the amazonInstance create method

image
  • async ec2 requets
  • catch ec2exception and retry with alternative instance types
  • update settings to require types= array
  • fix settings files type-o descriptions
  • remove some extra committed files

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Previously

image

@kevin-mcgoldrick kevin-mcgoldrick self-assigned this Feb 25, 2025
@kevin-mcgoldrick kevin-mcgoldrick marked this pull request as ready for review February 26, 2025 02:48
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Validated - LGTM!

@kevin-mcgoldrick kevin-mcgoldrick merged commit d550117 into master Mar 4, 2025
3 checks passed
@kevin-mcgoldrick kevin-mcgoldrick deleted the Ec2AsyncClient branch March 4, 2025 22:50
kevin-mcgoldrick added a commit that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants