Skip to content

Fix content-type on /v2/jobs/script/{jobid}#389

Merged
kevin-mcgoldrick merged 1 commit intomasterfrom
ContentType
Apr 21, 2025
Merged

Fix content-type on /v2/jobs/script/{jobid}#389
kevin-mcgoldrick merged 1 commit intomasterfrom
ContentType

Conversation

@kevin-mcgoldrick
Copy link
Collaborator

Fix content-type on /v2/jobs/script/{jobid}

  • Ensure XML response are returned with an XML content-encoding header so they can be compressed at the reverse-proxy layer
  • Simplify notFound responses

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin-mcgoldrick kevin-mcgoldrick merged commit 69a32c0 into master Apr 21, 2025
3 checks passed
@kevin-mcgoldrick kevin-mcgoldrick deleted the ContentType branch April 21, 2025 17:22
kevin-mcgoldrick added a commit that referenced this pull request Apr 22, 2025
* master:
  Fix ICE (#393)
  version updates (#392)
  Fix content-type on jobs/script/{jobid} (#389)
  InsufficientInstanceCapacity Fix (#391)
kevin-mcgoldrick added a commit that referenced this pull request Apr 22, 2025
* master:
  Fix ICE (#393)
  version updates (#392)
  Fix content-type on jobs/script/{jobid} (#389)
  InsufficientInstanceCapacity Fix (#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants