Skip to content

Increment 1% more coverage#397

Merged
kevin-mcgoldrick merged 3 commits intomasterfrom
LogicStepEditorTest
May 10, 2025
Merged

Increment 1% more coverage#397
kevin-mcgoldrick merged 3 commits intomasterfrom
LogicStepEditorTest

Conversation

@kevin-mcgoldrick
Copy link
Collaborator

@kevin-mcgoldrick kevin-mcgoldrick commented May 9, 2025 •
edited
Loading

Code Coverage

  • LogicStepEditor Testing to 87% coverage
  • ScriptEditor Testing to 85% coverage
  • ScriptRequestEditor Testing to 90% coverage

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@kevin-mcgoldrick kevin-mcgoldrick self-assigned this May 9, 2025
@kevin-mcgoldrick kevin-mcgoldrick changed the title LogicStepEditor Testing to 87% coverage Increment 1% more coverage May 9, 2025
Zakaria-Kofiro
Zakaria-Kofiro approved these changes May 10, 2025
View reviewed changes
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin-mcgoldrick kevin-mcgoldrick merged commit d541fc7 into master May 10, 2025
3 checks passed
@kevin-mcgoldrick kevin-mcgoldrick deleted the LogicStepEditorTest branch May 10, 2025 21:54
kevin-mcgoldrick added a commit that referenced this pull request May 10, 2025
@kevin-mcgoldrick
Merge branch 'master' into Primefaces15
2c8c5d5 
* master:
  Jexl3 Updates (#396)
  Increment 1% more coverage (#397)
  Fix Jobs Not Being Updated To Complete After Completing Test (#387)
  Bump org.jruby:jruby from 9.4.6.0 to 9.4.12.1 (#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zakaria-Kofiro Zakaria-Kofiro Zakaria-Kofiro approved these changes

Assignees

@kevin-mcgoldrick kevin-mcgoldrick

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevin-mcgoldrick @Zakaria-Kofiro