StandardScaling with separate constructor and fit methods to replace MeanStdScaling#107
Merged
StandardScaling with separate constructor and fit methods to replace MeanStdScaling#107
StandardScaling with separate constructor and fit methods to replace MeanStdScaling#107Conversation
mzgubic
force-pushed
the
mz/standardscaling
branch
from
4dd5a9a to
b939659
Compare
mzgubic
commented
Feb 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 98.74% 98.88% +0.14%
==========================================
Files 13 15 +2
Lines 159 179 +20
==========================================
+ Hits 157 177 +20
Misses 2 2
Continue to review full report at Codecov.
|
AlexRobson
reviewed
Mar 1, 2022
AlexRobson
reviewed
Mar 2, 2022
glennmoy
reviewed
May 11, 2022
Member
|
In general I'm in favour of these changes - I just don't think we should extend Oh and we should also document |
Co-authored-by: Glenn Moynihan <glenn.moynihan@invenialabs.co.uk>
mzgubic
changed the title
StandardScaling with separate constructor and fit methods to replace MeanStdScalingStandardScaling with separate constructor and fit methods to replace MeanStdScaling
Contributor
Author
|
Thank you both for reviewing, I think it's ready to go now. We went with the mutable approach so as not to inflate the API with an extra |
glennmoy
approved these changes
May 17, 2022
mzgubic
commented
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106, closes #59, closes #87
This is made non-breaking by deprecating the
MeanStdScaling.To do:
fit!in the docs