searchApi: fix "url" axios config override

[slint]

• Closes InvenioSearchApi: accidental use of both "baseURL" and "url" config #88.

[zzacharo]

@slint How is this different than the existing implementation?
Before the code was expecting an object e.g {url: '/me'} and this would end up in the non desired behaviour of calling /me/me when it was triggering a request. Now with the change passing the passing the same object I think it would lead to the same outcome no? Unless you pass explicitly the baseURL parameter which in that case it was already possible before...Do I miss something?

[slint]

Since now url is a destructured value from the passed object function argument, it will not be inside the ...config object. This means that it won't be passed at all to the axios.create(...) call

[zzacharo]

@slint But then you will not be able to pass the url parameter at all right?

[slint]

Yup. We have to discuss whether we'll directly pass-through the config to axios.create(...), or if we'll introduce an axiosConfig parameter to the ESSearchApi/InvneioSearchApi class constructor.

[zzacharo]

@ntarocco what do you think? I would be in favor I think of name spacing the axios config like axiosConfig and pass it through to axios.

[ntarocco]

Are we discussing this? #88
If yes, I should have already replied there :)

[zzacharo]

@ntarocco sorry I missed that. So just to confirm what you are proposing is just get through all the config passed to the axios instance right? In that case I wouldn't destructure the url parameter from the config passed and just pass through the config as it is. Then, it would be clear for the users (we should update the docs for that too) that this config is the same with what axios is accepting. @slint WDYT?

[slint]

I would go with an explicit axiosConfig parameter for the InvenioSearchApi constructor:

react-searchkit/src/lib/api/contrib/invenio/InvenioSearchApi.js

Lines 15 to 16 in 375f51d

	export class InvenioSearchApi {
	constructor(config) {

So something like:

export class InvenioSearchApi {
  constructor(serializers, axiosConfig, axiosInterceptors) {
    // NOTE: Would still validate the axiosConfig, but inside "initAxios"
    // this.validateConfig(config);
    this.initSerializers(serializers);
    this.initAxios(axiosConfig, axiosInterceptors);
  }
  ...
}

[slint]

LGTM (I can't review my own PR apparently)