Skip to content

[bug] Import Session bug fix#11456

Merged
SchrodingersGat merged 1 commit intoinventree:masterfrom
SchrodingersGat:data-import-fix
Mar 3, 2026
Merged

[bug] Import Session bug fix#11456
SchrodingersGat merged 1 commit intoinventree:masterfrom
SchrodingersGat:data-import-fix

Conversation

@SchrodingersGat
Copy link
Copy Markdown
Member

  • Check session completion when deleting rows
  • Ensures data import session is considered "complete" when deleting final rows

- Check session completion when deleting rows
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing labels Mar 3, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2026

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 9f0e30a
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69a6bf0ee4667f00084e3629

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 3, 2026

Merging this PR will degrade performance by 16.28%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 40 regressed benchmarks
✅ 4 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_api_list_performance[/api/part/] 76.5 ms 84.9 ms -9.91%
WallTime test_api_list_performance[/api/stock/] 164.6 ms 185.2 ms -11.12%
WallTime test_api_list_performance[/api/part/category/] 16.6 ms 19.4 ms -14.32%
WallTime test_api_list_performance[/api/stock/location/] 20.2 ms 23.2 ms -12.98%
WallTime test_api_list_performance[/api/parameter/template/] 9 ms 10.7 ms -15.93%
WallTime test_api_list_performance[/api/build/] 43.3 ms 48.6 ms -10.84%
WallTime test_api_list_performance[/api/order/so/shipment/] 22.4 ms 25.4 ms -12.06%
WallTime test_api_options_performance[/api/parameter/template/] 9.1 ms 10.9 ms -16.28%
WallTime test_search_performance[supplier] 14.6 ms 17 ms -14.12%
WallTime test_api_list_performance[/api/order/so/] 47 ms 50.8 ms -7.38%
WallTime test_search_performance[supplierpart] 41.3 ms 45.5 ms -9.29%
WallTime test_search_performance[all] 368.4 ms 404.3 ms -8.88%
WallTime test_api_list_performance[/api/parameter/] 11.7 ms 13.9 ms -15.91%
WallTime test_search_performance[stocklocation] 18 ms 20.9 ms -13.68%
WallTime test_api_list_performance[/api/company/] 18.4 ms 21.9 ms -16.23%
WallTime test_search_performance[returnorder] 29.2 ms 31.9 ms -8.38%
WallTime test_search_performance[salesordershipment] 22.2 ms 24.5 ms -9.45%
WallTime test_api_list_performance[/api/user/roles/] 8.7 ms 10.1 ms -14.1%
WallTime test_api_list_performance[/api/build/item/] 333.9 ms 379 ms -11.89%
WallTime test_search_performance[manufacturerpart] 22.6 ms 26.3 ms -14.2%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing SchrodingersGat:data-import-fix (9f0e30a) with master (41a617f)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (948818b) during the generation of this report, so 41a617f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.05%. Comparing base (948818b) to head (9f0e30a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11456      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files        1296     1296              
  Lines       59025    59029       +4     
  Branches     1935     1935              
==========================================
+ Hits        51974    51976       +2     
- Misses       6570     6572       +2     
  Partials      481      481              
Flag Coverage Δ
backend 89.22% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 91.71% <25.00%> (-0.01%) ⬇️
Backend General 93.37% <ø> (ø)
Frontend 70.91% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat SchrodingersGat merged commit cdcfdd8 into inventree:master Mar 3, 2026
71 of 74 checks passed
@SchrodingersGat SchrodingersGat deleted the data-import-fix branch March 3, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant