-
Notifications
You must be signed in to change notification settings - Fork 2.3k
test(ios): test iOS in release mode in addition to debug #8371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c1030bb to
d529c19
Compare
|
Perfect! Before adding the last commit that includes the upstream patch that fixes the issue, I wanted to make sure it reproduced the crash in testing since that is now the whole point of this PR. It did, here's what happened in the iOS release mode test: So these won't slip through again |
|
iOS release mode e2e appears to have become stuck: Going to check logs and see if I can determine why (was it a crash?) while re-running (was it a flake?) edit: unable to check logs, artifacts were uploaded without matrix name in them so they collided and release mode artifact wouldn't upload, no simulator log to check. Re-running now with a fix for that so we can inspect in future |
4b7cc5e to
0369a06
Compare
|
Test failure is Then a secondary is that during the re-run it hangs on test after |
this immediately reproduces a functions crash
no functional changes
0369a06 to
bb88e59
Compare
bb88e59 to
5c18eb6
Compare
- note that you still need the packager started, auth tests use a continueUrl that hits 8081, and tests will fail if the port refuses connection
This fixes a null-handling crash bug upstream that we trigger in functions and firestore It is preseent in 0.77.1, and 0.78.0 It is fixed upstream in 0.77.2 and 0.78.1 and 0.79.0 This patch may be dropped once one of those versions with the fixed is adopted here The crash would not be triggered in our "other" platform support as those don't rely on the native null handling in functions and firestore
5c18eb6 to
94da8dc
Compare
Description
This PR adds a release mode check to our CI to reproduce a functions and firestore crash that shows in release mode only on iOS
The actual issue is/was upstream, and releases are rolling out now, but the issue we can respond to here is that this showed up in release mode easily but we never saw it since we were not testing release mode.
The main change here is just to add release mode build/test scripts for iOS, then augment the iOS CI check to run a buildmode matrix
Related issues
Release Summary
No release will be triggered by any commits in this PR, the actual fix was upstream and I filed pick requests that have already been integrated for future upstream releases
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
With the commit on this PR you can run these and see the crash, until the upstream patch is integrated in our e2e app
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter