-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(auth): Make REVERSED_CLIENT_ID optional #8470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good - I like this - one comment to leave a breadcrumb for devs maybe, and it looks like it needs a javascript/typescript format for lint?
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it - I will admit that's a verbose warning but I couldn't think how to make it shorter and now devs will know what+why 🤷 - so looks good to me, thanks @MichaelVerdon
|
Thank you for this @MichaelVerdon! Will this be released soon @mikehardy? |
|
Yep - we have some tiny but still breaking changes (easy to handle, don't worry) that I'm waiting for a go/no-go on. Then I'll do a release later today that will have this either way. Cheers |
|
@mgray88 released now, as mentioned it was packaged with breaking changes but also as mentioned nothing to fear - the CHANGELOG for v22 has explicit information on how to handle the (in my opinion) small breaking changes. https://github.com/invertase/react-native-firebase/blob/main/CHANGELOG.md Cheers |
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter