Skip to content

Conversation

@MichaelVerdon
Copy link
Collaborator

@MichaelVerdon MichaelVerdon commented Apr 15, 2025

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 4:33pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good - I like this - one comment to leave a breadcrumb for devs maybe, and it looks like it needs a javascript/typescript format for lint?

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - I will admit that's a verbose warning but I couldn't think how to make it shorter and now devs will know what+why 🤷 - so looks good to me, thanks @MichaelVerdon

@mikehardy mikehardy merged commit a909d1b into main Apr 15, 2025
17 of 19 checks passed
@mikehardy mikehardy deleted the reverse_client_id branch April 15, 2025 18:30
@mgray88
Copy link
Contributor

mgray88 commented Apr 24, 2025

Thank you for this @MichaelVerdon! Will this be released soon @mikehardy?

@mikehardy
Copy link
Collaborator

Yep - we have some tiny but still breaking changes (easy to handle, don't worry) that I'm waiting for a go/no-go on. Then I'll do a release later today that will have this either way. Cheers

@mikehardy
Copy link
Collaborator

@mgray88 released now, as mentioned it was packaged with breaking changes but also as mentioned nothing to fear - the CHANGELOG for v22 has explicit information on how to handle the (in my opinion) small breaking changes. https://github.com/invertase/react-native-firebase/blob/main/CHANGELOG.md

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 Firebase Auth module requires REVERSE_CLIENT_ID for iOS even when only using email authentication

4 participants