Skip to content

Conversation

@DoctorJohn
Copy link
Contributor

Description

This PR fixes that the onAuthStateChanged function name was shadowed in one of the authentication examples.

Related issues

  • Starting with docs(auth): update examples to use modular API #8327, the callback's name conflicts with the onAuthStateChanged function's name when imported from the modular API. Previously, that was not an issue because the function was used via auth.onAuthStateChanged, which avoided the naming conflict.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • I double checked that this was the only example where I forgot to rename the callback to avoid naming conflicts
  • I'll triple-check once the docs preview gets posted by the bot :)

🔥


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2025 5:10pm

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - I appreciate it @DoctorJohn

@mikehardy mikehardy merged commit 0cbca93 into invertase:main May 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants