Add version requirement for magento version checker #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Does this in itself add the version-checker, it looks like it just specifies that it needs magento enterprise 1.12?
Author
There was a problem hiding this comment.
it does not add version checker as a dependency, it tells to version checked that this module is compatible with said magento version.
Contributor
There was a problem hiding this comment.
ah, cool. so shouldn't we add latest community as well?
jon-acker
pushed a commit
that referenced
this pull request
Nov 24, 2015
Add version requirement for magento version checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it the mage symfony container is not usable with modules or mage installations, which use magento version checker.