Skip to content

Add version requirement for magento version checker #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Add version requirement for magento version checker #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
"psr-0": {
"": "app/code/community"
}
},
"extra": {
"magento-version-ee": "^1.12.0"
Copy link
Contributor

@jon-acker jon-acker Nov 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this in itself add the version-checker, it looks like it just specifies that it needs magento enterprise 1.12?

Copy link
Author

@asarturas asarturas Nov 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not add version checker as a dependency, it tells to version checked that this module is compatible with said magento version.

Copy link
Contributor

@jon-acker jon-acker Nov 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, cool. so shouldn't we add latest community as well?

}
}