Skip to content

Add settings.json and Dockerfile COPY — implement missing PR #2 changes#3

Merged
saurabh-khanna merged 2 commits into
mainfrom
copilot/check-unmerged-branches
Mar 1, 2026
Merged

Add settings.json and Dockerfile COPY — implement missing PR #2 changes#3
saurabh-khanna merged 2 commits into
mainfrom
copilot/check-unmerged-branches

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 1, 2026

PR #2 ("Add persistent settings.json for Etherpad") was merged but its sole commit was an empty "Initial plan" — settings.json was never created and Dockerfile was never updated. Settings were still being wiped on every Appliku redeploy.

Changes

  • settings.json — Adds full Etherpad config committed to the repo:

    • Colibris skin, "title": "Invisible Notes", dark mode enabled
    • DB connection via ${DB_*} env-var placeholders (set in Appliku dashboard)
    • Admin/user accounts keyed to ${ADMIN_PASSWORD} / ${USER_PASSWORD} env vars
    • Pad defaults, rate limiting, cookie config, SSO client stubs
  • Dockerfile — Adds the COPY that was always the point of this work:

    FROM etherpad/etherpad:2.6.1
    COPY settings.json /opt/etherpad-lite/settings.json

Without this COPY, the base image's default settings.json overwrites any edits on every redeploy. With it, the committed config is baked into the image and survives redeployments.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: saurabh-khanna <54084054+saurabh-khanna@users.noreply.github.com>
Copilot AI changed the title [WIP] Check if task was successfully finished in main branch Add settings.json and Dockerfile COPY — implement missing PR #2 changes Mar 1, 2026
@saurabh-khanna saurabh-khanna marked this pull request as ready for review March 1, 2026 15:18
Copilot AI review requested due to automatic review settings March 1, 2026 15:18
@saurabh-khanna saurabh-khanna merged commit 5e37218 into main Mar 1, 2026
1 check passed
@saurabh-khanna saurabh-khanna deleted the copilot/check-unmerged-branches branch March 1, 2026 15:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a committed Etherpad settings.json and ensures it is baked into the container image so configuration no longer resets on redeploys (addressing the missing implementation from PR #2).

Changes:

  • Add a full settings.json configuration for the Etherpad instance (title/skin/db/auth/rate limits/etc.).
  • Update the Dockerfile to COPY the repository’s settings.json into /opt/etherpad-lite/settings.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
settings.json Introduces the intended persistent Etherpad configuration (env-var-driven DB creds, UI defaults, auth/user stubs).
Dockerfile Bakes the committed settings.json into the Etherpad image to prevent resets on redeploy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread settings.json
Comment on lines +98 to +102
"password": "${ADMIN_PASSWORD:null}",
"is_admin": true
},
"user": {
"password": "${USER_PASSWORD:null}",
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default password fallback ${ADMIN_PASSWORD:null} / ${USER_PASSWORD:null} will evaluate to the literal string "null" when the env var is missing, which creates a well-known weak credential if the deployment is misconfigured. Prefer having no default (so startup/login fails clearly) or choose a non-guessable default and document that ADMIN_PASSWORD/USER_PASSWORD must be set in the deployment environment.

Suggested change
"password": "${ADMIN_PASSWORD:null}",
"is_admin": true
},
"user": {
"password": "${USER_PASSWORD:null}",
"password": "${ADMIN_PASSWORD}",
"is_admin": true
},
"user": {
"password": "${USER_PASSWORD}",

Copilot uses AI. Check for mistakes.
Copilot AI mentioned this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants