Skip to content

Add Unsplash plugin#87

Merged
tobiaslins merged 2 commits intoinvoiceradar:mainfrom
rudivice:add-unsplash-plugin
Mar 7, 2026
Merged

Add Unsplash plugin#87
tobiaslins merged 2 commits intoinvoiceradar:mainfrom
rudivice:add-unsplash-plugin

Conversation

@rudivice
Copy link
Copy Markdown
Contributor

@rudivice rudivice commented Mar 5, 2026

Adds support for Unsplash photo subscriptions (Unsplash+).

Billing portal: https://unsplash.com/account/subscriptions/manage redirects to billing.unsplash.com (Stripe Customer Portal).

Uses the getInvoicesFromStripeBillingPortal snippet after following the automatic redirect to the Stripe billing portal.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59363058b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/unsplash.json Outdated
},
{
"action": "waitForURL",
"url": "https://billing.unsplash.com/*",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use recursive wildcard for billing portal URL match

The waitForURL guard in getDocuments is too narrow for Stripe portal redirects: https://billing.unsplash.com/* only matches a single path segment, while Stripe customer portal URLs are typically nested (for example /p/session/...), so this step can time out and prevent invoice extraction from running at all. Using a recursive pattern here avoids blocking document retrieval when the redirect includes deeper paths.

Useful? React with 👍 / 👎.

Comment thread plugins/unsplash.json Outdated
},
{
"action": "checkURL",
"url": "https://unsplash.com/*/account"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Accept direct /account URL in auth check

The auth check navigates to https://unsplash.com/account but then only accepts https://unsplash.com/*/account; if Unsplash keeps authenticated users on the direct /account route (without an extra segment), checkAuth will report a false unauthenticated state and unnecessarily trigger the login flow. The URL matcher should include the direct account route as well.

Useful? React with 👍 / 👎.

@rudivice
Copy link
Copy Markdown
Contributor Author

rudivice commented Mar 5, 2026

Der CI-Fehler ist kein Inhaltsproblem — der Workflow versucht den Branch direkt aus invoiceradar/plugins zu fetchen, obwohl er nur im Fork existiert. Bitte manuelles Review.

@tobiaslins tobiaslins merged commit dced96a into invoiceradar:main Mar 7, 2026
1 check failed
@tobiaslins
Copy link
Copy Markdown
Collaborator

danke fuer die integrationen!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants