outpaint !fix 1.png --out_direction top 64 error

[Cyx-0]

Traceback (most recent call last):
File "/Users/jc/InvokeAI/scripts/invoke.py", line 516, in do_postprocess
gen.apply_postprocessor(
File "/Users/jc/InvokeAI/ldm/generate.py", line 517, in apply_postprocessor
seed = args.seed
AttributeError: 'NoneType' object has no attribute 'seed'

[lstein]

Sorry you've found a bug. Could you fill out the bug report template so I know what branch you experienced this on, the platform, and so forth?

[psychedelicious]

@lstein This specific bug occurs when attempting to apply postprocessing to an image that does not have seed metadata, and whose filename does not match the format of <number>.<number>.png we use.

You can recreate it by taking an image without invokeai metadata, with a filename that is not like <number>.<number>.png - let's name it filename.png - and simply run !fix filename.png -G 0.75.

Rename it to our format e.g. 12345.12345.png, then run !fix 12345.12345.png -G 0.75 and now it succeeds (well it fails later while trying to add postprocessing metadata...).

The specific cause is metadata_from_png() falls back to legacy_metadata_load() which fails the regex match and args is set to None.

But the root cause is that a lot of our code assumes that it operates on images it created.

I've attempted to not assume anything about input images on the web UI, but I'm sure there are spots where I did make said assumption - reckon the CLI has a number of these spots as well.

[lstein]

I'm pretty sure that outcropping will not work as expected if the original prompt and seed cannot be recovered, because there won't be any guidance to fill in the missing parts. I will just end up generating an error message and refusing to proceed.

[psychedelicious]

@lstein I think you may be misunderstanding. The greater issue is that any !fix command tries to get a seed. Maybe it makes sense to bail out with outcropping if no seed is available.

But Gfpgan, codeformer, esrgan all break if there is no seed in metadata or a number in the file name. They should not.

[lstein]

I addressed these issues in #1207 and #1204.