Skip to content

[enhancement]: Make inpainting on the CLI explicit with a flag #1401

@psychedelicious

Description

@psychedelicious

Is there an existing issue for this?

  • I have searched the existing issues

Contact Details

No response

What should this feature add?

Currently, inpainting is triggered when a check of the user's init image determines there are pixels with an alpha < 255.

This leads to unexpected situations where the init image has some partial transparency which is not obvious to the user when viewing the image. The user expects a standard img2img to happen, but instead, inpainting over the transparent areas occurs.

For example, a user had an image with 12 pixels that had alpha < 255. This resulted in img2img doing inpainting on those 12 pixels. The result was not distinguishable from the init image, so it appeared something was wrong.

A simple solution is to make inpainting explicit, and then instead of checking if the image has transparency, check to see if it does not have transparent areas, and alert the user if so (and there was no mask provided).

Alternatives

Much much much more obvious warnings in the CLI when images have any transparency. This is not ideal because:

  • if you want to do inpainting you already know that you have transparent areas
  • terminal output is already pretty crowded and you may still miss it

Aditional Content

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions