Skip to content

Conversation

@lstein
Copy link
Collaborator

@lstein lstein commented Oct 23, 2022

The k_samplers come with a "karras" noise schedule which performs very well at low step counts but becomes noisy at higher ones.

This commit introduces a threshold (currently 30 steps) at which the k samplers will switch over from using karras to the older model noise schedule.

The k_samplers come with a "karras" noise schedule which performs
very well at low step counts but becomes noisy at higher ones.

This commit introduces a threshold (currently 30 steps) at which the
k samplers will switch over from using karras to the older model
noise schedule.
@psychedelicious
Copy link
Contributor

Sounds like a good option to exposed for advanced users.

@db3000
Copy link
Contributor

db3000 commented Oct 23, 2022

Is there a discontinuity there though, i.e. does 31 steps actually make it noisier than 30 steps because of the cutover?

@lstein
Copy link
Collaborator Author

lstein commented Oct 24, 2022

Is there a discontinuity there though, i.e. does 31 steps actually make it noisier than 30 steps because of the cutover?

I've tested the region around the switchover and I can't see a discontinuity.

@lstein
Copy link
Collaborator Author

lstein commented Oct 27, 2022

Sounds like a good option to exposed for advanced users.

I've added a "sticky" --karras_max option that allows you to adjust the switchover point. Can set to zero to use the LD noise model exclusively, or some high number (1000) to use the Karras schedule exclusively.

@lstein lstein merged commit 9436160 into development Oct 27, 2022
@lstein lstein deleted the switch-ksampler-noise-scheduler-adaptively branch October 27, 2022 20:48
@jjoshua2
Copy link

Does newer, faster samplers like k_dpmpp_2 affect this 30 cutover? Because this one is so good that 10 is OK, 15 is normal, and 20 is high and 30 is never needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants