Skip to content

Conversation

@mauwii
Copy link
Contributor

@mauwii mauwii commented Oct 28, 2022

  • in this way the action is used from the base repository
  • also use new secret HUGGINGFACE_TOKEN (username:token)
    • f.e. noreply@github.com:hf_lkaugfklagwrjglaslzfgkjzzf
  • change pr prompt file to validate_pr_prompt.txt

@lstein: you need to create the new secret as mentioned above

- in this way the action is used from the base repository
- also use new secret HUGGINGFACE_TOKEN (username:token)
  - f.e. `noreply@github.com:hf_lkaugfklagwrjglaslzfgkjzzf`
- change pr prompt file to validate_pr_prompt.txt
@mauwii
Copy link
Contributor Author

mauwii commented Oct 28, 2022

@lstein to add the secret, while in the repository, click on:

  1. settings
  2. secrets
  3. actions
  4. New Repository Secret
  5. name it HUGGINGFACE_TOKEN with content of username:huggingface_token
    (for me mauwii@provider.de:hf_blablabla)

mauwii and others added 2 commits October 28, 2022 19:35
imho this could also be deleted, not sure what it is used for
@lstein
Copy link
Collaborator

lstein commented Oct 28, 2022

I've done this using my HuggingFace account and access token. Should I remove the SD URL as well?

this enables running tests with diffferent models
@lstein lstein merged commit 104466f into invoke-ai:development Oct 28, 2022
@mauwii
Copy link
Contributor Author

mauwii commented Oct 28, 2022

I've done this using my HuggingFace account and access token. Should I remove the SD URL as well?

since secrets.SD_V1_4_URL shouldn't be reffered from the actions anymore it should be safe to remove it 👍🏻

@mauwii
Copy link
Contributor Author

mauwii commented Oct 28, 2022

@lstein only name:token as the secret, no line break in the end!

This is because there is a line break in the end of the secret: https://github.com/invoke-ai/InvokeAI/actions/runs/3347426747/jobs/5545396133#step:9:5

This is how it looks without the line break: https://github.com/mauwii/stable-diffusion/actions/runs/3347402241/jobs/5545344701#step:9:5

@mauwii mauwii deleted the protect-secrets-on-pr branch October 28, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants