Fix macOS install.sh by patching sysconfig#1488
Merged
Merged
Conversation
damian0815
force-pushed
the
fix_macos_installer
branch
from
a32c127 to
7707bc7
Compare
Contributor
|
@lstein; Please hold off on getting this into 'main'. I have some other fixes which, together with this, should probably go into a "Z-stream" release. I'm going to open a PR some time today/this evening |
1 task
Contributor
Author
|
this isn't shippable, see #1491 |
lstein
approved these changes
Nov 17, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Tildebyte should review this as well.
tildebyte
approved these changes
Nov 17, 2022
Contributor
|
@damian0815; This can be merged whenever you're comfortable with it |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, patch python sysconfig just before creating the venv so that extensions (greenlet & grpcio) can build.
Ref astral-sh/python-build-standalone#103, in particular the solution from @alecthomas posted here: astral-sh/python-build-standalone#103 (comment)
To use: checkout, cd into
installer, runcreate_installers.sh, copyInvokeAI-mac.zipinto an empty folder outside of your existing invokeAI install, unzip it and runinstall.sh.