fix (unified installer): various fixes#1506
Merged
Merged
Conversation
Contributor
|
does this include my fixes for macos building greenlet or is that somewhere separate? |
Contributor
Author
Separate, and I'd like to merge #1488 first, then rebase |
tildebyte
changed the title
damian0815
reviewed
Nov 17, 2022
Contributor
damian0815
left a comment
damian0815
left a comment
There was a problem hiding this comment.
seems ok other than the two comments i left on the things that seemed maybe off
- 'install'/'invoke' scripts: use venv 'activate' script - 'setup.py': - make 'install_requires" accurate - add more details for eventual use in pypi - 'invoke' scripts: "developer" console invocation simplified/better logging - requirements: - move 'clipseg' package out of installer and into requirements where it should be - bump/pin 'accelerate' package to 0.14.0 to bypass torch 1.13 SIGKILL issue on Windows (prep for when we decide to upgrade) - 'requirements.in': pin torch as well to reduce pip-compile's confusion - notebooks: delete unused/deprecated notebook installer Signed-off-by: Ben Alkov <ben.alkov@gmail.com>
Contributor
|
should i press merge then? |
lstein
approved these changes
Nov 18, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
I've reviewed the code and it looks good.
Closed
lstein
pushed a commit
that referenced
this pull request
Nov 20, 2022
'requirements.in':
- add picklescan
- finally find a good compromise for torch (==1.12.0) and
torchvision (==0.13.0) across all platforms
'invoke.sh: hotfix for MacOS - add `export PYTORCH_ENABLE_MPS_FALLBACK=1`
Signed-off-by: Ben Alkov <ben.alkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This list makes it look like there's lot going on for a single commit, but the changes are actually pretty small
Signed-off-by: Ben Alkov ben.alkov@gmail.com