Skip to content

Fix sampler changer not working.#171

Merged
blessedcoolant merged 2 commits into
invoke-ai:mainfrom
blessedcoolant:sampler-bug-fix
Aug 29, 2022
Merged

Fix sampler changer not working.#171
blessedcoolant merged 2 commits into
invoke-ai:mainfrom
blessedcoolant:sampler-bug-fix

Conversation

@blessedcoolant

Copy link
Copy Markdown
Collaborator

Sampler changer is no longer working because the variable was changed in dream.py to support -A ..Fixed that up with this PR. @lstein

@blessedcoolant blessedcoolant merged commit 41b26e0 into invoke-ai:main Aug 29, 2022
@blessedcoolant blessedcoolant deleted the sampler-bug-fix branch August 29, 2022 01:07
@lstein

lstein commented Aug 29, 2022

Copy link
Copy Markdown
Collaborator

Thanks! I see you've accepted the collaboration invite - great! From hereon I'd like to start a process in which there need to be at least two reviews of a PR before merging, with one of the reviews being mine. This was suggested by tildebyte and the recent spate of bug-introducing merges (many my fault) confirms the idea.

@blessedcoolant

Copy link
Copy Markdown
Collaborator Author

Thanks! I see you've accepted the collaboration invite - great! From hereon I'd like to start a process in which there need to be at least two reviews of a PR before merging, with one of the reviews being mine. This was suggested by tildebyte and the recent spate of bug-introducing merges (many my fault) confirms the idea.

Perfect. I merged two quick bug fixes but from here on I'll make sure there's two reviews for any PR - one being yours. Thank you for the invitation. Looking forward to doing some good stuff here.

austinbrown34 pushed a commit to cognidesign/InvokeAI that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants