Skip to content

feat: increase seed from int32 to uint32 #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blessedcoolant merged 2 commits into from
Jul 24, 2023
Merged

feat: increase seed from int32 to uint32 #3933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a75eb
feat: increase seed from int32 to uint32
psychedelicious Jul 24, 2023
66cdeba
fix(nodes): fix seed modulus operation
psychedelicious Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions invokeai/app/invocations/noise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ class Config(InvocationConfig):

@validator("seed", pre=True)
def modulo_seed(cls, v):
"""Returns the seed modulo SEED_MAX to ensure it is within the valid range."""
return v % SEED_MAX
"""Returns the seed modulo (SEED_MAX + 1) to ensure it is within the valid range."""
return v % (SEED_MAX + 1)

def invoke(self, context: InvocationContext) -> NoiseOutput:
noise = get_noise(
Expand Down
2 changes: 1 addition & 1 deletion invokeai/app/util/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def get_datetime_from_iso_timestamp(iso_timestamp: str) -> datetime.datetime:
return datetime.datetime.fromisoformat(iso_timestamp)


SEED_MAX = np.iinfo(np.int32).max
SEED_MAX = np.iinfo(np.uint32).max


def get_random_seed():
Expand Down
2 changes: 1 addition & 1 deletion invokeai/frontend/web/src/app/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export const NUMPY_RAND_MIN = 0;
export const NUMPY_RAND_MAX = 2147483647;
export const NUMPY_RAND_MAX = 4294967295;