Update Pytorch to ~2.1.0 in the installer script#5089
Merged
Conversation
Malrama
requested review from
ebr,
hipsterusername and
lstein
as code owners
hipsterusername
approved these changes
Nov 13, 2023
Member
|
Other torch dependencies should probably be bumped as well - Good catch 👀 |
Contributor
Author
It appears that the pinning happened here af239fa. The bug report attached to the PR says that some compiling was failing with newer versions of torchmetrics. I wonder if this is still the case and why that happened. |
lstein
approved these changes
Nov 13, 2023
lstein
left a comment
lstein
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for finding and fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
We use Pytorch ~2.1.0 as a dependency for InvokeAI, but the installer still installs 2.0.1 first until Invoke AIs dependencies kick in which causes it to get deleted anyway and replaced with 2.1.0. This is unnecessary and probably not wanted.
Fixed the dependencies for the installation script to install Pytorch ~2.1.0 to begin with.
P.s. Is there any reason why "torchmetrics==0.11.4" is pinned? What is the reason for that? Does that change with Pytorch 2.1? It seems to work since we use it already. It would be nice to know the reason.
Greetings
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?