Fix generation of image with s>1000 #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yes, especially when using |
Contributor
|
If this is merged, it will resolve #615. |
lstein
approved these changes
Oct 21, 2022
Collaborator
lstein
left a comment
lstein
left a comment
There was a problem hiding this comment.
Thank you. I'm merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with very high step counts for ancesteral samplers, ie 5k to 20k steps. that started causing errors in a recent patch with s >1000 as that results in a c = 0.
I am not sure this is correct as I don't understand what is exactly being constructed here and what all these values do, but it work with s>1k at least ;)