Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the navigation system from navigation-compose to navigation3 and updates Material3 to use the expressive API. The migration includes refactoring navigation setup, renaming UI components from "Screen" to "Pane" throughout the codebase, and adopting new Material3 expressive components.
- Migration from
androidx.navigation.composetoandroidx.navigation3 - Adoption of Material3 expressive API with new button and toggle components
- Systematic renaming of UI components from "Screen" to "Pane" nomenclature
Reviewed Changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
MainViewController.kt |
Simplified UI hierarchy by removing Surface wrapper |
MainNavHost.kt |
Complete navigation setup rewrite using navigation3 APIs with NavBackStack and NavDisplay |
build.gradle.kts files |
Updated dependencies to navigation3 and Material3 expressive versions |
| UI component files | Renamed from Screen to Pane and updated to use Material3 expressive components |
| Navigation controller | Refactored to work with NavBackStack instead of NavHostController |
| Button components | Replaced old button implementations with Material3 expressive variants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...nMain/kotlin/com/inwords/expenses/feature/expenses/ui/debts_list/DebtsListPaneDestination.kt
Outdated
Show resolved
Hide resolved
.../integration/base/src/commonMain/kotlin/com/inwords/expenses/integration/base/MainNavHost.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 85 out of 86 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
android/shared/feature/events/src/commonMain/kotlin/com/inwords/expenses/feature/events/ui/choose_person/ChoosePersonViewModel.kt:1
- The function
onPersonSelectednow performs both selection and confirmation (including navigation). This conflates two responsibilities that were previously separate. Consider renaming toonPersonConfirmedor restoring the separateonConfirmClickedmethod.
package com.inwords.expenses.feature.events.ui.choose_person
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../integration/base/src/commonMain/kotlin/com/inwords/expenses/integration/base/MainNavHost.kt
Show resolved
Hide resolved
...red/feature/menu/src/commonMain/kotlin/com/inwords/expenses/feature/menu/ui/MenuViewModel.kt
Show resolved
Hide resolved
...ses/src/commonMain/kotlin/com/inwords/expenses/feature/expenses/ui/list/ExpensesViewModel.kt
Show resolved
Hide resolved
...on/src/commonMain/kotlin/com/inwords/expenses/core/navigation/DefaultNavigationController.kt
Outdated
Show resolved
Hide resolved
...ore/navigation/src/commonMain/kotlin/com/inwords/expenses/core/navigation/DeeplinkHandler.kt
Outdated
Show resolved
Hide resolved
rugged-bl
force-pushed
the
navigation3-material3
branch
from
ce8f859 to
7029bad
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 85 out of 86 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
android/shared/feature/events/src/commonMain/kotlin/com/inwords/expenses/feature/events/ui/choose_person/ChoosePersonViewModel.kt:1
- The function
onPersonSelectednow automatically saves the selection and navigates away, removing the need foronConfirmClicked. This changes the UX from explicit confirmation to immediate action. This appears intentional based on the removal of the confirm button, but ensure this behavior change is desired and won't surprise users expecting a confirmation step.
package com.inwords.expenses.feature.events.ui.choose_person
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.