Add links to Privacy Policy and Terms of Use#108
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Privacy Policy and Terms of Use links throughout the application, along with several related improvements. The changes introduce a reusable LegalBlock component that displays clickable links to legal documents and integrates it into key user-facing screens.
Key changes:
- Created a new
LegalBlockcomposable component with links to Privacy Policy and Terms of Use - Added the legal block to the empty expenses screen and menu dialog
- Introduced a safe URI opening utility function (
openUriSafe) to handle potential failures gracefully - Updated string resources with legal-related text in both English and Russian
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
LegalBlock.kt |
New reusable component displaying Privacy Policy and Terms of Use links with click handlers |
uris.kt |
New utility function for safely opening URIs with error handling |
MenuDialog.kt |
Added legal block to menu dialog with appropriate callbacks |
MenuViewModel.kt |
Added click handlers for privacy policy and terms of use navigation |
MenuDialogDestination.kt |
Connected legal block callbacks to view model handlers |
ExpensesPane.kt |
Integrated legal block into empty state screen with layout adjustments |
strings.xml (ui-design) |
Added legal-related string resources in English and Russian |
strings.xml (expenses) |
Fixed typo: "Your" → "Yours" |
JoinEventViewModel.kt |
Standardized import alias naming convention (DesignRes) |
JoinEventPane.kt |
Fixed preview function name to match component name |
ui-design/build.gradle.kts |
Added dependency on ui-utils module for URI handling |
AndroidManifest.xml |
Added deep link path pattern for event URLs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
android/shared/core/ui-utils/src/commonMain/kotlin/com/inwords/expenses/core/ui/utils/uris.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.