IsRefreshing only when triggered by user#146
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af54c2b7a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...commonMain/kotlin/com/inwords/expenses/feature/expenses/ui/list/PullToRefreshStateManager.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR updates the pull-to-refresh functionality to only show the refreshing state when triggered by user interaction, rather than for all sync operations. The changes ensure that the refresh indicator is event-specific and respects minimum display time requirements.
Changes:
- Modified
PullToRefreshStateManagerto track refresh state per event ID instead of globally - Updated refresh logic to wait for sync operations to complete with proper timeouts
- Added test coverage to verify the new refresh behavior with proper timing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PullToRefreshStateManager.kt | Refactored to track event-specific refresh state and implement sync lifecycle management with minimum display time |
| ExpensesViewModel.kt | Updated to pass event ID when triggering user refresh |
| ExpensesViewModelRefreshTest.kt | Enhanced test to verify refresh behavior with timing and sync state changes |
| shared.versions.toml | Updated Cronet version dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.