Support AED and room-testing, Update wire version to 5.5.0#148
Merged
Support AED and room-testing, Update wire version to 5.5.0#148
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the AED (UAE Dirham) currency and introduces Room database migration testing with CI integration.
Changes:
- Adds AED currency support via database migration from version 1 to 2
- Introduces comprehensive Room migration testing infrastructure with Gradle Managed Devices
- Updates CI workflow to run device tests and reduces UI test timeout
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Migration1To2.kt | Implements idempotent migration to add AED currency for existing users |
| RoomOnCreateCallback.kt | Seeds AED currency for new database installations |
| AppDatabase.kt | Increments database version to 2 and registers migration |
| MigrationTest.kt | Adds migration test verifying AED insertion |
| 2.json | Room schema export for database version 2 |
| build.gradle.kts | Configures Room testing dependencies and Gradle Managed Device |
| AddExpensePane.kt | Adds AED to UI preview currency list |
| CurrencyExchanger.kt | Adds AED exchange rate |
| CreateEventPane.kt | Adds AED to UI preview currency list |
| shared.versions.toml | Adds room-testing dependency and updates Wire to 5.5.0 |
| android.yml | Runs device tests in CI and reduces timeout |
| android.instructions.md | Documents migration patterns and currency addition process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...commonMain/kotlin/com/inwords/expenses/integration/databases/data/migration/Migration1To2.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds AED support and introduces Room migration/testing with CI integration.
AppDatabaseto version 2, add idempotentMIGRATION_1_2inserting AED, seed AED inRoomOnCreateCallback, and commit schema2.json.androidDeviceTestwithroom-testing, orchestrator, and aMigrationTestverifying AED insertion; configure Gradle Managed Device for device tests.pixel6Api35AtdAndroidDeviceTest, reduce UI test timeout, and continue on failures; docs list new test commands.CurrencyExchangerrates and UI preview currency lists.room-testingto version catalog and bump Wire plugin to5.5.0.Written by Cursor Bugbot for commit e6fa6e8. This will update automatically on new commits. Configure here.