[Fix] Created dataset module and other module changes.#11
Conversation
Desc. I have successfully updated the checklist and dataset module to match with the new API. Permanentally deleted resources module.
I have updated the Nodes module and also updated the proposed changes.
Desc. I switched to a new branch to keep clean code, ready for a PR.
Pulled a commit from iobis/pyobis master which changed links to docs and source repo
I have completed writing dataset module as well as did some minor changes in functions of taxa module. I have also updated the README with the new terminology, and updated module usage.
|
@pieterprovoost @ocefpaf I'm sorry for pinging you here, but just wanted to request feedback on this PR. I know you'd have been very busy since a couple of weeks due to the GSoC timeline. May I ask for the code review, I have removed the Additionally, all tests in this branch have failed but I have worked on them and we will need one more patch to fix them (you can see the workflow run on my fork, https://github.com/ayushanand18/pyobis/actions/runs/2184556665 Status: Your feedback will help me improve this PR. Thanks in advance! :) |
|
@ayushanand18 most of the GSoC mentors are in the IOOS Code Sprint this week and we are quite busy. |
|
Thanks a ton @ocefpaf for the review. I am sorry for adding so many changes to a single PR. Thank you so much @pieterprovoost :) |
Don't be. There is nothing wrong with what you did. This is about how communities/people work and that usually takes time and iteration to find the best spot. Just be patient with us and we'll fine tune the PRs to take the most of your contributions. |
|
Thank you so much @ocefpaf :) I have learned so much from the Open Source community and especially during my time spent understanding the pyobis project. I have so much to learn more about, and I am excited about the future! |
Overview of changes
(Refer: [Fix] Integrated existing pyobis modules with OBIS v3 API #8 (comment) )
Notes for reviewers
You can run tests on your local machine whether the above 5 modules are working as expected.
Questions for reviewers
No questions for reviewers.