Skip to content

publish to PyPI#44

Merged
7yl4r merged 4 commits into
iobis:masterfrom
ocefpaf:publish_pypi
Sep 1, 2022
Merged

publish to PyPI#44
7yl4r merged 4 commits into
iobis:masterfrom
ocefpaf:publish_pypi

Conversation

@ocefpaf
Copy link
Copy Markdown
Collaborator

@ocefpaf ocefpaf commented Jul 26, 2022

@sckott can you grant @7yl4r and myself PyPI maintainer status for this package? This PR will automate the releases based on GH actions but we need set set the token and be able to yank releases if necessary.

@7yl4r We can merge this one but we can only issue releases after we add the token to this repo.

@7yl4r
Copy link
Copy Markdown
Collaborator

7yl4r commented Aug 16, 2022

@ocefpaf : what should we do if we don't hear from @sckott

@7yl4r 7yl4r mentioned this pull request Aug 16, 2022
@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 16, 2022

@ocefpaf : what should we do if we don't hear from @sckott

Ideally we should keep the project here. If we don't hear from him we can move it to the IOOS org where we would have the right permissions. But I'd like to avoid that if we can. (And use a different name for PyPI :-/)

@sckott
Copy link
Copy Markdown
Contributor

sckott commented Aug 30, 2022

working on it

@sckott
Copy link
Copy Markdown
Contributor

sckott commented Aug 30, 2022

@ocefpaf you should be getting an invitation email from pypi.

@7yl4r what's your pypi username?

@7yl4r
Copy link
Copy Markdown
Collaborator

7yl4r commented Aug 30, 2022

It's 7yl4r. I just set it up. Thanks!

@sckott
Copy link
Copy Markdown
Contributor

sckott commented Aug 30, 2022

invitiatoin sent

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 30, 2022

Thanks @sckott!

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Aug 30, 2022

@7yl4r this PR is ready to go. The last step is to add the PyPI token to this repository secrets. We will need someone with elevated rights here to do so. Maybe @pieterprovoost can help us out?

@pieterprovoost
Copy link
Copy Markdown
Member

@ocefpaf @7yl4r Added PYPI_API_TOKEN, can you please check?

@7yl4r 7yl4r merged commit c2097fc into iobis:master Sep 1, 2022
@ocefpaf ocefpaf deleted the publish_pypi branch September 1, 2022 18:43
@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Sep 1, 2022

@ocefpaf @7yl4r Added PYPI_API_TOKEN, can you please check?

B/c we cannot access the token config the only way for us to check is to mind a new release. @ayushanand18 and @7yl4r do you believe we are ready for one?

@pieterprovoost
Copy link
Copy Markdown
Member

Sorry about that, I have bumped your privileges.

@7yl4r
Copy link
Copy Markdown
Collaborator

7yl4r commented Sep 1, 2022

I see the secret; looks good. I just created a release, but it appears the github action did not trigger. Should we be using on:release [ref] instead of using if: ${{github.event_name == 'release'}}?

@ocefpaf
Copy link
Copy Markdown
Collaborator Author

ocefpaf commented Sep 1, 2022

That if-clause works on my projects but is is worth testing on release only. I use it that way b/c we run on PRs are a tarball test and then on release to publish.

7yl4r added a commit that referenced this pull request Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants