Skip to content

use version number from the tags#87

Merged
7yl4r merged 2 commits into
iobis:masterfrom
ocefpaf:fix_version_init
Sep 5, 2022
Merged

use version number from the tags#87
7yl4r merged 2 commits into
iobis:masterfrom
ocefpaf:fix_version_init

Conversation

@ocefpaf
Copy link
Copy Markdown
Collaborator

@ocefpaf ocefpaf commented Sep 5, 2022

This should fix step 1 from #84.

Comment thread .gitignore Outdated
Function_Changes.md
.vscode
_build
pyobis/_version.py No newline at end of file
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to track this file. It should be shipped only on tagged releases but no need to keep it in the repo.

Comment thread pyobis/__init__.py
occurrence.search(geometry='POLYGON((30.1 10.1, 10 20, 20 40, 40 40, 30.1 10.1))')
"""

__version__ = "1.2.5"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the lines below, when we create a tag on GitHub, a _version.py file will be written and the installation will read the version from it. That way we need to change the version in a single place, the tag, and everything else is automatic.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful. I am learning so many great tricks through this project. Thanks!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly all I can teach is packaging tricks. At least I can save you two from the packaging hell so you can focus on fun coding :-)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually having fun coding on this project. And thank you for keeping me out of those trappy things so that I would keep doing that fun :)

@ocefpaf ocefpaf requested a review from 7yl4r September 5, 2022 13:39
@7yl4r 7yl4r merged commit 4a392b8 into iobis:master Sep 5, 2022
@ocefpaf ocefpaf deleted the fix_version_init branch September 5, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants