Merged
Conversation
working and streamlined for the time when most of our testing will be done using the django server.
bcolloran
changed the title
Contributor
Author
|
WIP towards closing #749 |
wlach
force-pushed
the
webpack-config-consolidation
branch
from
e86cc73 to
4f6b425
Compare
wlach
force-pushed
the
webpack-config-consolidation
branch
from
4f6b425 to
23aeff4
Compare
wlach
force-pushed
the
webpack-config-consolidation
branch
from
23aeff4 to
78f74bf
Compare
wlach
force-pushed
the
webpack-config-consolidation
branch
from
78f74bf to
cbc72c2
Compare
Contributor
|
@bcolloran hey, so I think I have this mostly working, except that I'm not sure where I should be getting the assets from extremely-alpha.iodide.io? https://extremely-alpha.iodide.app/iodide.eval-frame.dev.html returns a 404 It was working ok when everything was served from the same origin on heroku. :) |
Contributor
Author
Contributor
Author
|
ah i see, i think we need to merge to master so that the other changes in the webpack config are picked up by mike's build script. so i'm going to go ahead and merge this because now that we're deploying off stable, doing so won't break our public site, yay :-) |
Contributor
Author
|
commented at #674 (comment) -- i think we want https for the heroku instance. then i think we'll be good to go. |
Contributor
Author
|
upgraded to heroku hobby instance, all good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wlach -- with @mdboom having completed #748, can you jump in to get this over the line?
i think you should be able to build off this PR, which a bunch of changes to consolidate our webpack config and get things working and streamlined since most of our testing will be done using the django server going forward.
things to note:
since we're not yet really versioning our resources, i don't think we need to have e.g.
iodide.X.jsfor X = {master, stable, dev, iodide-server} all floating around. so this config just uses the 'dev' label everywhere other than tags (since really all this stuff is "dev" until we decide to get serious about versioning).we'll probably need to move some of the stuff about which origin a given instance is being served from to the
.envfile (which will need to be configured per origin anyway since we'll need different GH secrets etc). this way, the.envfile can pass the correct origin into the python and webpack templates.i think other changes will be needed, but this should be a start.