-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: per-workspace script cleanup and CI path filtering #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
44e9f5c
refactor: rename root script orchestrators to :all suffix
ioncache abb29e1
refactor: remove duplicate script aliases from data-sanitization
ioncache 5092816
refactor: remove duplicate script aliases from data-sanitization-log-…
ioncache 2c8d2ca
ci: split into per-workspace workflows with path filtering
ioncache fbf234d
fix(ci): build data-sanitization before log-providers in CI
ioncache ec331c3
docs: update CI badges for split workflows, add log-providers badges
ioncache 9e51180
ci: add shared lint configs to path filters, drop unused PR permission
ioncache File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: CI (data-sanitization-log-providers) | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'packages/data-sanitization-log-providers/**' | ||
| - 'packages/data-sanitization/**' | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - '.oxlintrc.json' | ||
| - '.oxfmtrc.json' | ||
| - '.github/workflows/ci-data-sanitization-log-providers.yml' | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - 'packages/data-sanitization-log-providers/**' | ||
| - 'packages/data-sanitization/**' | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - '.oxlintrc.json' | ||
| - '.oxfmtrc.json' | ||
| - '.github/workflows/ci-data-sanitization-log-providers.yml' | ||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [22, 24] | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: yarn | ||
| - run: | | ||
| git config --global user.name "CI" | ||
| git config --global user.email "ci@localhost" | ||
| git config --global init.defaultBranch main | ||
| - run: yarn install --immutable | ||
| - run: yarn workspace data-sanitization build | ||
| - run: yarn workspace data-sanitization-log-providers format:check | ||
| - run: yarn workspace data-sanitization-log-providers lint:ci | ||
| - run: yarn workspace data-sanitization-log-providers build | ||
| - run: yarn workspace data-sanitization-log-providers test:coverage | ||
| - name: Report coverage | ||
| if: matrix.node-version == 24 | ||
| uses: davelosert/vitest-coverage-report-action@02f3c2e641286b7fa308cd3e430783103ce6103b # v2 | ||
| with: | ||
| json-summary-path: coverage/coverage-summary.json | ||
| json-final-path: coverage/coverage-final.json | ||
| working-directory: packages/data-sanitization-log-providers | ||
| - name: Extract coverage percentage | ||
| id: coverage | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| run: echo "percentage=$(jq '.total.lines.pct' packages/data-sanitization-log-providers/coverage/coverage-summary.json)" >> "$GITHUB_OUTPUT" | ||
| - name: Update coverage badge | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| uses: schneegans/dynamic-badges-action@0e50b8bad39e7e1afd3e4e9c2b7dd145fad07501 # v1.8.0 | ||
| with: | ||
| auth: ${{ secrets.GIST_SECRET }} | ||
| gistID: ${{ vars.COVERAGE_GIST_ID }} | ||
| filename: data-sanitization-log-providers-coverage-badge-config.json | ||
| label: coverage | ||
| message: ${{ steps.coverage.outputs.percentage }}% | ||
| valColorRange: ${{ steps.coverage.outputs.percentage }} | ||
| maxColorRange: 100 | ||
| minColorRange: 0 | ||
| - name: Update coverage report in Gist | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| env: | ||
| COVERAGE_GIST_ID: ${{ vars.COVERAGE_GIST_ID }} | ||
| GIST_SECRET: ${{ secrets.GIST_SECRET }} | ||
| run: yarn workspace data-sanitization-log-providers node ../data-sanitization/scripts/update-coverage-gist.mjs --package-name data-sanitization-log-providers | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| name: CI (data-sanitization) | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'packages/data-sanitization/**' | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - '.oxlintrc.json' | ||
| - '.oxfmtrc.json' | ||
| - '.github/workflows/ci-data-sanitization.yml' | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - 'packages/data-sanitization/**' | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - '.oxlintrc.json' | ||
| - '.oxfmtrc.json' | ||
| - '.github/workflows/ci-data-sanitization.yml' | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [22, 24] | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: yarn | ||
| - run: | | ||
| git config --global user.name "CI" | ||
| git config --global user.email "ci@localhost" | ||
| git config --global init.defaultBranch main | ||
| - run: yarn install --immutable | ||
| - run: yarn workspace data-sanitization format:check | ||
| - run: yarn workspace data-sanitization lint:ci | ||
| - run: yarn workspace data-sanitization build | ||
| - run: yarn workspace data-sanitization test:coverage | ||
| - name: Report coverage | ||
| if: matrix.node-version == 24 | ||
| uses: davelosert/vitest-coverage-report-action@02f3c2e641286b7fa308cd3e430783103ce6103b # v2 | ||
| with: | ||
| json-summary-path: coverage/coverage-summary.json | ||
| json-final-path: coverage/coverage-final.json | ||
| working-directory: packages/data-sanitization | ||
| - name: Extract coverage percentage | ||
| id: coverage | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| run: echo "percentage=$(jq '.total.lines.pct' packages/data-sanitization/coverage/coverage-summary.json)" >> "$GITHUB_OUTPUT" | ||
| - name: Update coverage badge | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| uses: schneegans/dynamic-badges-action@0e50b8bad39e7e1afd3e4e9c2b7dd145fad07501 # v1.8.0 | ||
| with: | ||
| auth: ${{ secrets.GIST_SECRET }} | ||
| gistID: ${{ vars.COVERAGE_GIST_ID }} | ||
| filename: data-sanitization-coverage-badge-config.json | ||
| label: coverage | ||
| message: ${{ steps.coverage.outputs.percentage }}% | ||
| valColorRange: ${{ steps.coverage.outputs.percentage }} | ||
| maxColorRange: 100 | ||
| minColorRange: 0 | ||
| - name: Update coverage report in Gist | ||
| if: matrix.node-version == 24 && github.event_name == 'push' | ||
| env: | ||
| COVERAGE_GIST_ID: ${{ vars.COVERAGE_GIST_ID }} | ||
| GIST_SECRET: ${{ secrets.GIST_SECRET }} | ||
| run: yarn workspace data-sanitization node scripts/update-coverage-gist.mjs --package-name data-sanitization | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: CI (root) | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - 'lint-staged.config.mjs' | ||
| - '*.md' | ||
| - 'docs/**' | ||
| - '.github/**' | ||
| - '!.github/workflows/ci-data-sanitization.yml' | ||
| - '!.github/workflows/ci-data-sanitization-log-providers.yml' | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - 'package.json' | ||
| - 'yarn.lock' | ||
| - '.yarnrc.yml' | ||
| - 'tsconfig.json' | ||
| - '.markdownlint.json' | ||
| - '.markdownlintignore' | ||
| - 'lint-staged.config.mjs' | ||
| - '*.md' | ||
| - 'docs/**' | ||
| - '.github/**' | ||
| - '!.github/workflows/ci-data-sanitization.yml' | ||
| - '!.github/workflows/ci-data-sanitization-log-providers.yml' | ||
|
|
||
| jobs: | ||
| ci-root: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false | ||
| - run: corepack enable | ||
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 | ||
| with: | ||
| node-version: 22 | ||
| cache: yarn | ||
| - run: yarn install --immutable | ||
| - run: yarn format:check | ||
| - run: yarn lint:ci |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.