Skip to content

Save files on execution with a config setting#9

Merged
ioncodes merged 3 commits intoioncodes:masterfrom
Plutoberth:saveOnExecute
Jul 4, 2020
Merged

Save files on execution with a config setting#9
ioncodes merged 3 commits intoioncodes:masterfrom
Plutoberth:saveOnExecute

Conversation

@Plutoberth
Copy link
Copy Markdown
Contributor

When running or debugging scripts in vscode, all open dirty editors are automatically saved. I added this functionality as a config option ("IDACode.saveOnExecute") that is enabled by default.

@ioncodes
Copy link
Copy Markdown
Owner

ioncodes commented Jul 4, 2020

Thanks for the PR, I'll check this out ASAP!

@ioncodes
Copy link
Copy Markdown
Owner

ioncodes commented Jul 4, 2020

This PR contains an async issue. The file gets saved but IDA has already executed the script by the time VS Code saves the file. On another execution it then successfully executes the script. I fixed that locally by calling the send function in the .then promise handler. I'll push to the PR and merge it in a bit! Thanks for implementing this feature!

@ioncodes ioncodes merged commit 15b9672 into ioncodes:master Jul 4, 2020
@Plutoberth
Copy link
Copy Markdown
Contributor Author

This PR contains an async issue. The file gets saved but IDA has already executed the script by the time VS Code saves the file. On another execution it then successfully executes the script. I fixed that locally by calling the send function in the .then promise handler. I'll push to the PR and merge it in a bit! Thanks for implementing this feature!

My bad, I barely use js\ts and I misread some documentation about .then. Thanks for this awesome plugin!

@Plutoberth Plutoberth deleted the saveOnExecute branch July 4, 2020 14:36
@ioncodes
Copy link
Copy Markdown
Owner

ioncodes commented Jul 4, 2020

I'm glad you like the plugin!

fengjixuchui added a commit to fengjixuchui/idacode that referenced this pull request Jul 8, 2020
Merge pull request ioncodes#9 from Plutoberth/saveOnExecute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants