feat(ios): close #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-ricardomoreirasilva
force-pushed
the
feat/RMET-3425/open-webview-ios
branch
3 times, most recently
from
dbd0e5e to
a66aa91
Compare
OS-ricardomoreirasilva
changed the title
Update iOS framework to the latest version. Implement close feature. Instead of managing the opened router, just manage the opened view controller and, when 'close' is triggered, dismiss it. The view itself will take care of everything related to the operation. Add a close error, when there's no view to close. Add a 'handleResult' to manage the External Browser and Web View event reaction. To make every operation synchronised, the events should only be triggered when the display view is completed. That's why we add the present method. Update TypeScript definition so that methods return Promises. References: https://outsystemsrd.atlassian.net/browse/RMET-3427
Return a new error when the URL doesn't start with http or https.
OS-ricardomoreirasilva
force-pushed
the
feat/RMET-3425/open-webview-ios
branch
from
a66aa91 to
c9e625e
Compare
OS-ricardomoreirasilva
requested review from
IT-MikeS,
ItsChaceD,
OS-martacarlos and
alexgerardojacinto
OS-martacarlos
approved these changes
Jun 20, 2024
IT-MikeS
approved these changes
Jun 20, 2024
IT-MikeS
pushed a commit
that referenced
this pull request
Jul 25, 2024
# 1.0.0-dev.1 (2024-07-25) ### Bug Fixes * capacitor bridge ([5021349](5021349)) * decodeIfPresent for optional param ([29d4356](29d4356)) * use correct parameter for openInWebView in definitions.ts ([94e36cd](94e36cd)) ### Features * add documentation for isSchemeValid function ([2f39e9e](2f39e9e)) * add external browser options to sample app ([6f621f6](6f621f6)) * add webview customizations ([9ba1d27](9ba1d27)) * **android:** implement open with external browser ([150404b](150404b)) * check if url scheme is valid before trying to open it ([119d4d0](119d4d0)) * implement browserPageLoaded and browserFinished events ([e70ab0c](e70ab0c)) * implement event listeners for CustomTabs ([00071db](00071db)) * implement openInWebView for Android ([70ad5e5](70ad5e5)) * **ios:** add openInExternalBrowser ([#1](#1)) ([17a7c59](17a7c59)) * **ios:** add openInSystemBrowser ([#3](#3)) ([fa5b065](fa5b065)) * **ios:** add openinwebview ([#5](#5)) ([1fc3485](1fc3485)) * **ios:** close ([#8](#8)) ([075cb45](075cb45)) * **ios:** fix error code and messages ([#18](#18)) ([2508dec](2508dec)) * **ios:** webview error page ([0677a20](0677a20)) * update android lib ([816866c](816866c)) * update capacitor bridge with new version of OSInAppBrowserLib-Android ([65a1e1a](65a1e1a)) * update dependency to OSInAppBrowserLib-Android library ([503eb86](503eb86)) * update xcframework ([b4d26c8](b4d26c8))
OS-martacarlos
pushed a commit
that referenced
this pull request
Aug 21, 2024
# 1.0.0-dev.1 (2024-07-25) ### Bug Fixes * capacitor bridge ([5021349](5021349)) * decodeIfPresent for optional param ([29d4356](29d4356)) * use correct parameter for openInWebView in definitions.ts ([94e36cd](94e36cd)) ### Features * add documentation for isSchemeValid function ([2f39e9e](2f39e9e)) * add external browser options to sample app ([6f621f6](6f621f6)) * add webview customizations ([9ba1d27](9ba1d27)) * **android:** implement open with external browser ([150404b](150404b)) * check if url scheme is valid before trying to open it ([119d4d0](119d4d0)) * implement browserPageLoaded and browserFinished events ([e70ab0c](e70ab0c)) * implement event listeners for CustomTabs ([00071db](00071db)) * implement openInWebView for Android ([70ad5e5](70ad5e5)) * **ios:** add openInExternalBrowser ([#1](#1)) ([17a7c59](17a7c59)) * **ios:** add openInSystemBrowser ([#3](#3)) ([fa5b065](fa5b065)) * **ios:** add openinwebview ([#5](#5)) ([1fc3485](1fc3485)) * **ios:** close ([#8](#8)) ([075cb45](075cb45)) * **ios:** fix error code and messages ([#18](#18)) ([2508dec](2508dec)) * **ios:** webview error page ([0677a20](0677a20)) * update android lib ([816866c](816866c)) * update capacitor bridge with new version of OSInAppBrowserLib-Android ([65a1e1a](65a1e1a)) * update dependency to OSInAppBrowserLib-Android library ([503eb86](503eb86)) * update xcframework ([b4d26c8](b4d26c8))
IT-MikeS
pushed a commit
that referenced
this pull request
Aug 21, 2024
# 1.0.0-dev.1 (2024-08-21) ### Bug Fixes * android dep ref ([caaaf2c](caaaf2c)) * capacitor bridge ([5021349](5021349)) * ci release process ([38687ed](38687ed)) * decodeIfPresent for optional param ([29d4356](29d4356)) * more ci fixes ([a20f93c](a20f93c)) * podspec not published ([d031b43](d031b43)) * use correct parameter for openInWebView in definitions.ts ([94e36cd](94e36cd)) ### Features * add documentation for isSchemeValid function ([2f39e9e](2f39e9e)) * add external browser options to sample app ([6f621f6](6f621f6)) * add webview customizations ([9ba1d27](9ba1d27)) * **android:** implement open with external browser ([150404b](150404b)) * check if url scheme is valid before trying to open it ([119d4d0](119d4d0)) * implement browserPageLoaded and browserFinished events ([e70ab0c](e70ab0c)) * implement event listeners for CustomTabs ([00071db](00071db)) * implement openInWebView for Android ([70ad5e5](70ad5e5)) * **ios:** add openInExternalBrowser ([#1](#1)) ([17a7c59](17a7c59)) * **ios:** add openInSystemBrowser ([#3](#3)) ([fa5b065](fa5b065)) * **ios:** add openinwebview ([#5](#5)) ([1fc3485](1fc3485)) * **ios:** close ([#8](#8)) ([075cb45](075cb45)) * **ios:** fix error code and messages ([#18](#18)) ([2508dec](2508dec)) * **ios:** webview error page ([0677a20](0677a20)) * swap xcframework for cocoapod + update android aar ([521ce27](521ce27)) * update android lib ([816866c](816866c)) * update capacitor bridge with new version of OSInAppBrowserLib-Android ([65a1e1a](65a1e1a)) * update dependency to OSInAppBrowserLib-Android library ([503eb86](503eb86)) * update xcframework ([b4d26c8](b4d26c8))
IT-MikeS
pushed a commit
that referenced
this pull request
Aug 22, 2024
# 1.0.0 (2024-08-22) ### Bug Fixes * android dep ref ([caaaf2c](caaaf2c)) * android dep ref ([f02d5e1](f02d5e1)) * capacitor bridge ([5021349](5021349)) * ci ([4df108d](4df108d)) * ci release process ([38687ed](38687ed)) * ci release process ([effccbd](effccbd)) * decodeIfPresent for optional param ([29d4356](29d4356)) * more ci fixes ([a20f93c](a20f93c)) * more ci fixes ([d39fb72](d39fb72)) * podspec not published ([d031b43](d031b43)) * podspec not published ([17d1417](17d1417)) * use correct parameter for openInWebView in definitions.ts ([94e36cd](94e36cd)) ### Features * add documentation for isSchemeValid function ([2f39e9e](2f39e9e)) * add external browser options to sample app ([6f621f6](6f621f6)) * add webview customizations ([9ba1d27](9ba1d27)) * **android:** implement open with external browser ([150404b](150404b)) * check if url scheme is valid before trying to open it ([119d4d0](119d4d0)) * implement browserPageLoaded and browserFinished events ([e70ab0c](e70ab0c)) * implement event listeners for CustomTabs ([00071db](00071db)) * implement openInWebView for Android ([70ad5e5](70ad5e5)) * **ios:** add openInExternalBrowser ([#1](#1)) ([17a7c59](17a7c59)) * **ios:** add openInSystemBrowser ([#3](#3)) ([fa5b065](fa5b065)) * **ios:** add openinwebview ([#5](#5)) ([1fc3485](1fc3485)) * **ios:** close ([#8](#8)) ([075cb45](075cb45)) * **ios:** fix error code and messages ([#18](#18)) ([2508dec](2508dec)) * **ios:** webview error page ([0677a20](0677a20)) * swap xcframework for cocoapod + update android aar ([521ce27](521ce27)) * swap xcframework for cocoapod + update android aar ([ea7f639](ea7f639)) * update android lib ([816866c](816866c)) * update capacitor bridge with new version of OSInAppBrowserLib-Android ([65a1e1a](65a1e1a)) * update dependency to OSInAppBrowserLib-Android library ([503eb86](503eb86)) * update xcframework ([b4d26c8](b4d26c8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update iOS framework to the latest version.
Implement close feature. Instead of managing the opened router, just manage the opened view controller and, when 'close' is triggered, dismiss it. The view itself will take care of everything related to the operation.
Add a close error, when there's no view to close.
Add a 'handleResult' to manage the External Browser and Web View event reaction. To make every operation synchronised, the events should only be triggered when the display view is completed. That's why we add the
presentmethod.Update TypeScript definition so that methods return Promises.
Return a new error when the URL doesn't start with http or https.
References: https://outsystemsrd.atlassian.net/browse/RMET-3427