fix(camera): reject promise on web input cancel event#1958
Merged
jcesarmobile merged 4 commits intoionic-team:mainfrom Dec 14, 2023
andrzejSulkowski:pwa-camera-update
Merged
fix(camera): reject promise on web input cancel event#1958jcesarmobile merged 4 commits intoionic-team:mainfrom andrzejSulkowski:pwa-camera-update
jcesarmobile merged 4 commits intoionic-team:mainfrom
andrzejSulkowski:pwa-camera-update
Conversation
jcesarmobile
approved these changes
Dec 13, 2023
Member
jcesarmobile
left a comment
jcesarmobile
left a comment
There was a problem hiding this comment.
Thanks for the PR, I've fixed some lint issues, next time you can run npm run fmt and it will fix the issues automatically.
cancel event is pretty new, so it will only fix the issue for new browsers, but that's better than nothig
jcesarmobile
changed the title
jcesarmobile
added a commit
that referenced
this pull request
Dec 14, 2023
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds promise rejections for the pwa camera plugin upon cancelation of the input element.
Previously, in the web implementation of the PWA camera plugin, the promise would remain unresolved if the user cancelled the input, as it was solely reliant on the 'change' event. This behaviour differed from the iOS/Android implementation, where the promise is rejected under similar circumstances.
closes #1050