fix(menu-button): Not visible if toolbar has primary color #15847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi I still seem to have this problem with I have tried everything to change the color of the hamburger side menu button (for ios, Android is fine), as outlines int this post If I set button color to white in the dev tools, it works, but if I set in in scss, it is just not picked up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The menu-button was not visible if the toolbar got the primary color.
Should it merged? It's just a first step because the back-button has already MANY css variables, the menu button has not. So I think the menu button has to be extended afterwards. So this PR only fixes the color!
Changes proposed in this pull request:
Ionic Version: 4
Fixes: #15546 #15545