Skip to content

fix(slides): prevent the setting of slideindex to a value outside of … #12398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 79 commits into from
Closed

fix(slides): prevent the setting of slideindex to a value outside of … #12398

wants to merge 79 commits into from

Conversation

alexkonovalov
Copy link

@alexkonovalov alexkonovalov commented Jul 18, 2017 •
edited
Loading

Short description of what this resolves:

Drag of the last slide sets the slide index to N+1 where N is the index of the last slide in the range.

Changes proposed in this pull request:

  • Set the current index to the last slide if it gets out of range.

Ionic Version: 3.x

Fixes: #10208

brandyscarney and others added 30 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (ionic-team#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (ionic-team#12043)
7a1342c 
fixes ionic-team#7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (ioni…
c7645ee 
…c-team#11965)

fixes ionic-team#6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes ionic-team#12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes ionic-team#11988
@AmitMY @manucorporat
feat(item-reorder): add side support (ionic-team#11642)
63f728f 
fixes ionic-team#11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (ionic-team#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes ionic-team#12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@danbucholtz
chore(build): strictly enforce metadata
00fbded
jgw96 and others added 22 commits July 6, 2017 12:42
@jgw96
chore(build): import spawnSync from correct package
923e3b2
@danbucholtz
chore(lockfile): idk why this thing keeps updating
3e3a00b
@manucorporat
fix(sliding-item): ionSwipe event is fired (ionic-team#12157)
b5aa304 
fixes ionic-team#12146
@janpio @manucorporat
docs(content): type Sroll => Scroll (ionic-team#12281)
693c1c5
@manucorporat
fix(select): not activated on enter in input field
ad25cd1 
fixes ionic-team#12202
@RoopeHakulinen @mhartington
fix(navigation): ts2.4 compatibility
08be9dc 
Closes ionic-team#12233. Closes ionic-team#12235
@danbucholtz
chore(dependencies): recreate lockfile with npm 5.1
9ffc52b
@pranjal-goswami @brandyscarney
docs(events): fix syntax error (ionic-team#12317)
347c260 
Need to access member using `this` keyword outside constructor
@mhartington @danbucholtz
chore(generator): remove ionicPage for now (ionic-team#12347)
6d8da0a
@danbucholtz
chore(changelog): update to 3.5.1
2153940 
update to 3.5.1
@danbucholtz
chore(changelog): 3.5.2 release
acb6fac 
3.5.2 release
@danbucholtz
chore(changelog): 3.5.2 upgrade instructions
889b49f
@danbucholtz
chore(changelog): additional details about upgrading and updating app…
4c13535 
…-scripts
@b264 @brandyscarney
docs(toast): add import statement in usage (ionic-team#12278)
d23b9f7 
Cannot use ToastController without knowing from where to import it
@peterpeterparker @danbucholtz
chore(changelog): update changelog to save app-scripts as devDependency
f7fce5f
@danbucholtz
chore(changelog): 3.5.2 changelog
ce46c24 
3.5.2 changelog
@danbucholtz
fix(app): restore getActiveNav api
2d49e10 
restore getActiveNav api
@danbucholtz
chore(dependencies): add angular/tsc-wrapper to package.json to avoid…
ab511c4 
… npm issues people are having
@danbucholtz
chore(dependencies): removing tsc-wrapped since angular explicitely s…
cec718c 
…ays not to do this
@danbucholtz
chore(dependencies): update the lock file
c4e7552
@danbucholtz
chore(changelog): 3.5.3 release
5b9fe5e
@alexkonovalov
fix(slides): prevent the setting of slideindex to a value outside of …
40e295e 
…the slides range
@alexkonovalov alexkonovalov mentioned this pull request Jul 18, 2017
Closed
RickeyWard
RickeyWard approved these changes Jan 15, 2018
View reviewed changes
Copy link

@RickeyWard RickeyWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable constraint strategy, I would like to see this merged. Also would resolve duplicate issue #10740

chuwy
chuwy approved these changes Jan 16, 2018
View reviewed changes
Copy link

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@RickeyWard RickeyWard RickeyWard approved these changes

@chuwy chuwy chuwy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.