fix(app): set user-select for iOS contenteditable #18369
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
contenteditable
in iOS mobile cannot be selected/editedIssue Number: #18368
What is the new behavior?
Set
user-select: text
specifically forios [contenteditable]
to override app.scss rulehtml.plt-mobile ion-app
=>user-select: none
. Safari's webkit implementation ofuser-select
affects anycontenteditable
children, rendering them unselectable/uneditable, so this fix ensures the behavior is consistent with Chrome, FireFox, etc. and thatcontenteditable
s are selectable/editable despite the rest of the children of<ion-app>
being unselectable.Does this introduce a breaking change?