chore: remove unused sass variables #28363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
averyjohnston,
brandyscarney and
sean-perkins
as code owners
brandyscarney
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
This looks good. The build passes and I can't see any issues with removing these. Should we update the linter here to check for unused variables:
ionic-framework/core/package.json
Line 85 in feda7a0
Alternatively, we could make that part of the updates with the Sass guidelines in FW-5394.
averyjohnston
approved these changes
Oct 18, 2023
|
I can look into adding a linter in a separate PR! I might also snag that for a hack day |
sean-perkins
pushed a commit
that referenced
this pull request
Oct 27, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> This project has several unused Sass variables still in the code base. The team would like to remove these. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removed unused Sass variables ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> The original scope of this ticket was for checkbox only, but many other components had unused sass variables, so I decided to tackle everything all at once. Since these variables are not used anywhere: 1. The build should pass 2. There should be no screenshot diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
This project has several unused Sass variables still in the code base. The team would like to remove these.
What is the new behavior?
Does this introduce a breaking change?
Other information
The original scope of this ticket was for checkbox only, but many other components had unused sass variables, so I decided to tackle everything all at once.
Since these variables are not used anywhere: