Skip to content

chore: remove unused sass variables #28363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023
Merged

chore: remove unused sass variables #28363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9c368
chore: remove unused sass variables
liamdebeasi Oct 16, 2023
3e1f093
remove other vars
liamdebeasi Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions core/src/components/action-sheet/action-sheet.ios.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,6 @@ $action-sheet-ios-title-font-weight: 400 !default;
/// @prop - Font weight of the action sheet title when it has a sub title
$action-sheet-ios-title-with-sub-title-font-weight: 600 !default;

/// @prop - Border width of the action sheet title
$action-sheet-ios-title-border-width: $hairlines-width !default;

/// @prop - Border style of the action sheet title
$action-sheet-ios-title-border-style: solid !default;

/// @prop - Border color alpha of the action sheet title
$action-sheet-ios-title-border-color-alpha: .08 !default;

/// @prop - Border color of the action sheet title
$action-sheet-ios-title-border-color: rgba($text-color-rgb, $action-sheet-ios-title-border-color-alpha) !default;


// Action Sheet Subtitle
// --------------------------------------------------

Expand Down Expand Up @@ -129,9 +116,6 @@ $action-sheet-ios-button-background-selected: var(--ion-colo
/// @prop - Destructive text color of the action sheet button
$action-sheet-ios-button-destructive-text-color: ion-color(danger, base) !default;

/// @prop - Background color of the action sheet cancel button
$action-sheet-ios-button-cancel-background: $background-color !default;

/// @prop - Font weight of the action sheet cancel button
$action-sheet-ios-button-cancel-font-weight: 600 !default;

Expand Down
6 changes: 0 additions & 6 deletions core/src/components/action-sheet/action-sheet.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ $action-sheet-md-button-padding-bottom: $action-sheet-md-button-
/// @prop - Padding start of the action sheet button
$action-sheet-md-button-padding-start: $action-sheet-md-button-padding-end !default;

/// @prop - Background color of the action sheet button
$action-sheet-md-button-background: transparent !default;

// Action Sheet Icon
// --------------------------------------------------

Expand All @@ -104,6 +101,3 @@ $action-sheet-md-icon-margin-bottom: 0 !default;

/// @prop - Margin start of the icon in the action sheet button
$action-sheet-md-icon-margin-start: 0 !default;

/// @prop - Color of the icon in the action sheet button
$action-sheet-md-icon-color: $action-sheet-md-title-color !default;
3 changes: 0 additions & 3 deletions core/src/components/alert/alert.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@ $alert-md-button-text-color: ion-color(primary, base) !default;
/// @prop - Background color of the alert button
$alert-md-button-background-color: transparent !default;

/// @prop - Background color of the alert activated button
$alert-md-button-background-color-activated: ion-color(primary, base, .04) !default;

/// @prop - Border radius of the alert button
$alert-md-button-border-radius: 2px !default;

Expand Down
64 changes: 0 additions & 64 deletions core/src/components/button/button.ios.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,6 @@ $button-ios-font-size: dynamic-font-max(16px, 3)
/// @prop - Font weight of the button text
$button-ios-font-weight: 500 !default;

/// @prop - Background color of the button
$button-ios-background-color: ion-color(primary, base) !default;

/// @prop - Text color of the button
$button-ios-text-color: ion-color(primary, contrast) !default;

/// @prop - Background color of the activated button
$button-ios-background-color-activated: ion-color(primary, shade) !default;

/// @prop - Opacity of the activated button
$button-ios-opacity-activated: 1 !default;

/// @prop - Opacity of the button on hover
$button-ios-opacity-hover: .8 !default;

/// @prop - Background color of the focused button
$button-ios-background-color-focused: ion-color(primary, shade) !default;

/// @prop - Opacity of the button when disabled
$button-ios-opacity-disabled: .5 !default;


// iOS Large Button
// --------------------------------------------------

Expand Down Expand Up @@ -129,30 +107,6 @@ $button-ios-outline-border-style: solid !default;
/// @prop - Border radius of the outline button
$button-ios-outline-border-radius: $button-ios-border-radius !default;

/// @prop - Border color of the outline button
$button-ios-outline-border-color: $button-ios-background-color !default;

/// @prop - Text color of the outline button
$button-ios-outline-text-color: $button-ios-background-color !default;

/// @prop - Background color of the outline button
$button-ios-outline-background-color: transparent !default;

/// @prop - Text color of the activated outline button
$button-ios-outline-text-color-activated: ion-color(primary, contrast) !default;

/// @prop - Background color of the activated outline button
$button-ios-outline-background-color-activated: $button-ios-background-color !default;

/// @prop - Opacity of the activated outline button
$button-ios-outline-opacity-activated: 1 !default;

/// @prop - Background color alpha of the focused outline button
$button-ios-outline-background-color-alpha-focused: .25 !default;

/// @prop - Background color of the focused outline button
$button-ios-outline-background-color-focused: ion-color(primary, base, $button-ios-outline-background-color-alpha-focused) !default;

// iOS Clear Button
// --------------------------------------------------

Expand All @@ -167,30 +121,12 @@ $button-ios-clear-font-weight: normal !default;
/// @prop - Letter spacing of the button
$button-ios-letter-spacing: 0 !default;

/// @prop - Border color of the clear button
$button-ios-clear-border-color: transparent !default;

/// @prop - Background color of the clear button
$button-ios-clear-background-color: transparent !default;

/// @prop - Background color of the activated clear button
$button-ios-clear-background-color-activated: $button-ios-clear-background-color !default;

/// @prop - Opacity of the activated clear button
$button-ios-clear-opacity-activated: .4 !default;

/// @prop - Text color of the clear button on hover
$button-ios-clear-text-color-hover: $button-ios-background-color !default;

/// @prop - Opacity of the clear button on hover
$button-ios-clear-opacity-hover: .6 !default;

/// @prop - Background color alpha of the focused clear button
$button-ios-clear-background-color-alpha-focused: .25 !default;

/// @prop - Background color of the focused clear button
$button-ios-clear-background-color-focused: ion-color(primary, base, $button-ios-clear-background-color-alpha-focused) !default;

// iOS Round Button
// --------------------------------------------------

Expand Down
85 changes: 0 additions & 85 deletions core/src/components/button/button.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,9 @@ $button-md-letter-spacing: 0.06em;
/// @prop - Box shadow of the button
$button-md-box-shadow: 0 3px 1px -2px rgba(0, 0, 0, .2), 0 2px 2px 0 rgba(0, 0, 0, .14), 0 1px 5px 0 rgba(0, 0, 0, .12) !default;

/// @prop - Opacity of the activated button
$button-md-opacity-activated: 1 !default;

/// @prop - Box shadow of the activated button
$button-md-box-shadow-activated: 0 5px 5px -3px rgba(0, 0, 0, .2), 0 8px 10px 1px rgba(0, 0, 0, .14), 0 3px 14px 2px rgba(0, 0, 0, .12) !default;

/// @prop - Background color of the ripple on the button
$button-md-ripple-background-color: $text-color-step-400 !default;

/// @prop - Opacity of the button when disabled
$button-md-opacity-disabled: .5 !default;

// Material Design Large Button
// --------------------------------------------------

Expand Down Expand Up @@ -102,82 +93,6 @@ $button-md-small-min-height: 2.1em !default;
/// @prop - Font size of the small button
$button-md-small-font-size: dynamic-font(13px) !default;


// Material Design Outline Button
// --------------------------------------------------

/// @prop - Border width of the outline button
$button-md-outline-border-width: 1px !default;

/// @prop - Border style of the outline button
$button-md-outline-border-style: solid !default;

/// @prop - Background color of the outline button
$button-md-outline-background-color: transparent !default;

/// @prop - Box shadow of the outline button
$button-md-outline-box-shadow: none !default;

/// @prop - Background color alpha of the outline button on hover
$button-md-outline-background-color-alpha-hover: .1 !default;

/// @prop - Background color of the outline button on hover
$button-md-outline-background-color-hover: rgba($text-color-rgb, $button-md-outline-background-color-alpha-hover) !default;

/// @prop - Background color of the activated outline button
$button-md-outline-background-color-activated: transparent !default;

/// @prop - Box shadow of the activated outline button
$button-md-outline-box-shadow-activated: none !default;

/// @prop - Opacity of the activated outline button
$button-md-outline-opacity-activated: 1 !default;

/// @prop - Background color alpha of the focused outline button
$button-md-outline-background-color-alpha-focused: .1 !default;

/// @prop - Background color of the focused outline button
$button-md-outline-background-color-focused: ion-color(primary, base, $button-md-outline-background-color-alpha-focused) !default;

// Material Design Clear Button
// --------------------------------------------------

/// @prop - Border color of the clear button
$button-md-clear-border-color: transparent !default;

/// @prop - Background color of the clear button
$button-md-clear-background-color: transparent !default;

/// @prop - Box shadow of the clear button
$button-md-clear-box-shadow: none !default;

/// @prop - Opacity of the clear button
$button-md-clear-opacity: 1 !default;

/// @prop - Background color alpha of the activated clear button
$button-md-clear-background-color-alpha-activated: .1 !default;

/// @prop - Background color of the activated clear button
$button-md-clear-background-color-activated: rgba($text-color-rgb, $button-md-clear-background-color-alpha-activated) !default;

/// @prop - Box shadow of the activated clear button
$button-md-clear-box-shadow-activated: $button-md-clear-box-shadow !default;

/// @prop - Background color alpha of the clear button on hover
$button-md-clear-background-color-alpha-hover: .1 !default;

/// @prop - Background color of the clear button on hover
$button-md-clear-background-color-hover: rgba($text-color-rgb, $button-md-clear-background-color-alpha-hover) !default;

/// @prop - Background color of the ripple on the clear button
$button-md-clear-ripple-background-color: $text-color-step-600 !default;

/// @props - Background color of the focused clear button
$button-md-clear-background-color-alpha-focused: .1 !default;

/// @props - Background color of the focused clear button
$button-md-clear-background-color-focused: ion-color(primary, base, $button-md-clear-background-color-alpha-focused) !default;

// Material Design Round Button
// --------------------------------------------------

Expand Down
30 changes: 0 additions & 30 deletions core/src/components/checkbox/checkbox.ios.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,12 @@
/// @prop - Background color of the checkbox when off
$checkbox-ios-background-color-off: $item-ios-background !default;

/// @prop - Background color of the checkbox when on
$checkbox-ios-background-color-on: ion-color(primary, base) !default;

/// @prop - Background color of focus indicator for checkbox when focused
$checkbox-ios-background-color-focused: ion-color(primary, tint) !default;

/// @prop - Size of the checkbox icon
$checkbox-ios-icon-size: dynamic-font-max(26px, 2.538) !default;

/// @prop - Border color of the checkbox icon when off
$checkbox-ios-icon-border-color-off: rgba($text-color-rgb, 0.23) !default;

/// @prop - Border color of the checkbox icon when on
$checkbox-ios-icon-border-color-on: $checkbox-ios-background-color-on !default;

/// @prop - Border width of the checkbox icon
$checkbox-ios-icon-border-width: dynamic-font(1px) !default;

Expand All @@ -32,27 +23,6 @@ $checkbox-ios-icon-border-style: solid !default;
/// @prop - Border radius of the checkbox icon
$checkbox-ios-icon-border-radius: 50% !default;

/// @prop - Width of the checkmark border in the checkbox
$checkbox-ios-checkmark-border-width: 1px !default;

/// @prop - Style of the checkmark border in the checkbox
$checkbox-ios-checkmark-border-style: solid !default;

/// @prop - Color of the checkmark border in the checkbox
$checkbox-ios-checkmark-border-color: ion-color(primary, contrast) !default;

/// @prop - Top of the checkmark in the checkbox
$checkbox-ios-checkmark-top: calc($checkbox-ios-icon-size / 6) !default;

/// @prop - Start of the checkmark in the checkbox
$checkbox-ios-checkmark-start: calc($checkbox-ios-icon-size / 3 + 1px) !default;

/// @prop - Width of the checkmark in the checkbox
$checkbox-ios-checkmark-width: calc($checkbox-ios-icon-size / 6 + 1px) !default;

/// @prop - Height of the checkmark in the checkbox
$checkbox-ios-checkmark-height: calc($checkbox-ios-icon-size * 0.5) !default;

/// @prop - Opacity of the disabled checkbox
$checkbox-ios-disabled-opacity: $form-control-ios-disabled-opacity !default;

Expand Down
21 changes: 0 additions & 21 deletions core/src/components/checkbox/checkbox.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,41 +10,20 @@ $checkbox-md-disabled-opacity: $form-control-md-disabled-opacity !defa
/// @prop - Background color of the checkbox icon when off
$checkbox-md-icon-background-color-off: $item-md-background !default;

/// @prop - Background color of focus indicator for checkbox when focused
$checkbox-md-background-color-focused: ion-color(primary, tint) !default;

/// @prop - Background color of the checkbox icon when on
$checkbox-md-icon-background-color-on: ion-color(primary, base) !default;

/// @prop - Size of the checkbox icon
/// The icon size does not use dynamic font
/// because it does not scale in native.
$checkbox-md-icon-size: 18px !default;

/// @prop - Width of the checkbox icon checkmark
$checkbox-md-icon-checkmark-width: 2px !default;

/// @prop - Style of the checkbox icon checkmark
$checkbox-md-icon-checkmark-style: solid !default;

/// @prop - Color of the checkbox icon checkmark
$checkbox-md-icon-checkmark-color: ion-color(primary, contrast) !default;

/// @prop - Border width of the checkbox icon
$checkbox-md-icon-border-width: 2px !default;

/// @prop - Border style of the checkbox icon
$checkbox-md-icon-border-style: solid !default;

/// @prop - Border radius of the checkbox icon
$checkbox-md-icon-border-radius: 2px !default;

/// @prop - Border color of the checkbox icon when off
$checkbox-md-icon-border-color-off: rgb($text-color-rgb, 0.60) !default;

/// @prop - Border color of the checkbox icon when on
$checkbox-md-icon-border-color-on: ion-color(primary, base) !default;

/// @prop - Transition duration of the checkbox
$checkbox-md-transition-duration: 180ms !default;

Expand Down
9 changes: 0 additions & 9 deletions core/src/components/datetime/datetime.ios.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,6 @@ $datetime-ios-border-color: 0.55px solid $background-color-step-200 !def
/// @prop - Padding for content
$datetime-ios-padding: 16px !default;

/// @prop - Height of the time picker
$datetime-ios-time-height: 28px !default;

/// @prop - Width of the time picker
$datetime-ios-time-width: 68px !default;

/// @prop - Border radius of the time picker
$datetime-ios-time-border-radius: 8px !default;

/// @prop - The font size at which layouts may change to accommodate Dynamic Type
$datetime-dynamic-font-breakpoint: 24px !default;

Expand Down
2 changes: 1 addition & 1 deletion core/src/components/datetime/datetime.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "./datetime.vars";
@import "../../themes/ionic.globals";

// Datetime
// --------------------------------------------------
Expand Down
10 changes: 0 additions & 10 deletions core/src/components/datetime/datetime.vars.scss
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions core/src/components/fab-button/fab-button.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ $fab-md-box-shadow-activated: 0 7px 8px -4px rgba(0, 0, 0, .
/// @prop - Background color of the button
$fab-md-background-color: ion-color(primary, base) !default;

/// @prop - Background color of the activated button
$fab-md-background-color-activated: ion-color(primary, contrast) !default;

/// @prop - Text color of the button
$fab-md-text-color: ion-color(primary, contrast) !default;

Expand Down
Loading